Page MenuHomePhabricator

change passing ScheduleDAG with ScheduleDAGInstrs when creating HazaradRec
AcceptedPublic

Authored by atheel.ma on May 14 2018, 12:42 AM.

Details

Reviewers
atrick
stoklund
Summary
  • let CreateTargetMIHazardRecognizer and CreateTargetPostRAHazardRecognizer to use ScheduleDAGInstrs instead of ScheduleDAG.

this way we will be able to use AliasAnalysis inside the HazaradRec

Diff Detail

Repository
rL LLVM

Event Timeline

atheel.ma created this revision.May 14 2018, 12:42 AM
atrick accepted this revision.May 14 2018, 10:28 AM

Fine with me. I don't know if it's possible anyone still uses ScoreBoardHazardRecognizer with SelectionDAG scheduler, but they really need to stop doing that.

This revision is now accepted and ready to land.May 14 2018, 10:28 AM

thanks,
I dont have commit permissions:

Permission to llvm-mirror/llvm.git denied to atheelm

dmgreen added inline comments.
include/llvm/CodeGen/TargetInstrInfo.h
54

Nit: two semicolons

atheel.ma updated this revision to Diff 146982.May 15 2018, 6:56 PM

removed extra ";"

atheel.ma marked an inline comment as done.May 15 2018, 6:57 PM

two semicolons: fixed

anyone can push it please?