Page MenuHomePhabricator

atheel.ma (Atheel Massalha)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2018, 11:56 PM (63 w, 3 d)

Recent Activity

May 23 2018

atheel.ma added a comment to D46817: change passing ScheduleDAG with ScheduleDAGInstrs when creating HazaradRec.

anyone can push it please?

May 23 2018, 7:33 PM
atheel.ma added a comment to D46801: add getAA in ScheduleDAG for using in HazardRec.

so Hfinkel, are you going to push it?

May 23 2018, 7:30 PM

May 21 2018

atheel.ma added a comment to D46928: implantation example for new AliasAnalysis functions (getAddressesDistance + ModRefSameBuffer).

O1 == nullptr is taken from aliasCheck()
If I want to change it to !nullptr I should do it in 2 functions in a different commit
same for the loop (its correct to start from 1 because 0 was checked before... using iterator is not the best solution)

May 21 2018, 11:31 PM
atheel.ma updated the diff for D46928: implantation example for new AliasAnalysis functions (getAddressesDistance + ModRefSameBuffer).

Fix some comments
remove duplicated functions

May 21 2018, 11:28 PM

May 16 2018

atheel.ma added a comment to D46928: implantation example for new AliasAnalysis functions (getAddressesDistance + ModRefSameBuffer).

thanks,
mail sent to llvm-dev,
ofcurse Im aware of the "duplicated code", this is only a temporary implementation,
Okm will discuss it on llvm-dev .

May 16 2018, 8:54 PM

May 15 2018

atheel.ma added a comment to D46864: add 2 functions to the ALiasAnalysis interface (getAddressesDistance + ModRefSameBuffer).

implementation example added under:
https://reviews.llvm.org/D46928#1100610

May 15 2018, 8:47 PM
atheel.ma added a comment to D46928: implantation example for new AliasAnalysis functions (getAddressesDistance + ModRefSameBuffer).

The use is inside a target specific function:

May 15 2018, 8:46 PM
atheel.ma created D46928: implantation example for new AliasAnalysis functions (getAddressesDistance + ModRefSameBuffer).
May 15 2018, 8:45 PM
atheel.ma added a comment to D46801: add getAA in ScheduleDAG for using in HazardRec.

thanks Atrick for the explanation,

May 15 2018, 7:05 PM
atheel.ma added a comment to D46817: change passing ScheduleDAG with ScheduleDAGInstrs when creating HazaradRec.

two semicolons: fixed

May 15 2018, 6:57 PM
atheel.ma updated the diff for D46817: change passing ScheduleDAG with ScheduleDAGInstrs when creating HazaradRec.

removed extra ";"

May 15 2018, 6:56 PM
atheel.ma added a comment to D46801: add getAA in ScheduleDAG for using in HazardRec.

I dont have commit permissions:

May 15 2018, 9:22 AM
atheel.ma added a comment to D46864: add 2 functions to the ALiasAnalysis interface (getAddressesDistance + ModRefSameBuffer).

Hi,
its very similar to the BasicAliasAnalysis aliasCheck() functions,
the declerations for the private function is:

May 15 2018, 9:18 AM
atheel.ma created D46864: add 2 functions to the ALiasAnalysis interface (getAddressesDistance + ModRefSameBuffer).
May 15 2018, 1:43 AM

May 14 2018

atheel.ma added a comment to D46817: change passing ScheduleDAG with ScheduleDAGInstrs when creating HazaradRec.

thanks,
I dont have commit permissions:

May 14 2018, 8:51 PM
atheel.ma created D46817: change passing ScheduleDAG with ScheduleDAGInstrs when creating HazaradRec.
May 14 2018, 12:42 AM

May 13 2018

atheel.ma updated the diff for D46801: add getAA in ScheduleDAG for using in HazardRec.

in SchedulePostRATDList it cant be nullptr because its a pass that intilize the AA in his run

May 13 2018, 10:23 PM
atheel.ma updated the diff for D46801: add getAA in ScheduleDAG for using in HazardRec.
May 13 2018, 10:20 PM
atheel.ma updated the diff for D46801: add getAA in ScheduleDAG for using in HazardRec.

comment for nullptr return added
added function getAA() to the base class also for cases that you have dynamic pointer of base class ScheduleDAGInstrs that holds SchedulePostRATDList

May 13 2018, 10:18 PM

May 12 2018

atheel.ma updated the diff for D46801: add getAA in ScheduleDAG for using in HazardRec.
May 12 2018, 11:48 PM
atheel.ma added a comment to D46243: Move Schedule class to header file for allowing inheritance.

Hi again.
as I see now that passing ScheduleDAGMI instead of ScheduleDAG is not a good idea,
I think ScheduleDAG is better becuase we dont want to force the user to use the implementation of the opensource (ScheduleDAGMI),
if we pass ScheduleDAG then the user can inherit from ScheduleDAG and make his own pass, but if we change it to ScheduleDAGMI (which is declared and implemented in an open source *CPP* file - meant cant inherit from it, then the user will be stuck with this implemntations of ScheduleDAGMI...

May 12 2018, 11:35 PM
atheel.ma retitled D46801: add getAA in ScheduleDAG for using in HazardRec from add getAA in ScheduleDAGM for using in HazardRec to add getAA in ScheduleDAG for using in HazardRec.
May 12 2018, 11:24 PM
atheel.ma retitled D46801: add getAA in ScheduleDAG for using in HazardRec from add getAA in ScheduleDAGMI for using in HazardRec to add getAA in ScheduleDAGM for using in HazardRec.
May 12 2018, 11:24 PM
atheel.ma edited reviewers for D46801: add getAA in ScheduleDAG for using in HazardRec, added: sunfish; removed: dblaikie.
May 12 2018, 11:24 PM
atheel.ma updated the diff for D46801: add getAA in ScheduleDAG for using in HazardRec.

add getAA in ScheduleDAGMI for using in HazardRec
add getAA in SchedulePostRATDListfor using in HazardRec

May 12 2018, 11:21 PM
atheel.ma created D46801: add getAA in ScheduleDAG for using in HazardRec.
May 12 2018, 10:44 PM

May 7 2018

atheel.ma added a comment to D46243: Move Schedule class to header file for allowing inheritance.

Hi Andy,

May 7 2018, 4:34 AM

Apr 30 2018

atheel.ma updated the diff for D46243: Move Schedule class to header file for allowing inheritance.
  • run clang-format
  • moved member functions implementation to the cpp file
  • added header description
  • capitalized header guard name
Apr 30 2018, 10:07 PM
atheel.ma added a comment to D46243: Move Schedule class to header file for allowing inheritance.

thanks for your comment,
yes, I need to reuse "scheduleRegions" code. why its so important to avoid implicit coupling between the target code and machine independent code in this class?

Apr 30 2018, 1:48 AM
atheel.ma added a comment to D46243: Move Schedule class to header file for allowing inheritance.

this is my first commit suggestion in the open source. I hope the change is clear enough.

Apr 30 2018, 12:18 AM
atheel.ma created D46243: Move Schedule class to header file for allowing inheritance.
Apr 30 2018, 12:15 AM