Page MenuHomePhabricator

[cmake] work around a race in Sphinx.
Needs ReviewPublic

Authored by brooks on May 6 2018, 9:37 AM.

Details

Reviewers
chandlerc
Summary

Create the target directory before calling sphinx to put files in it.
Sphinx has a race where it fails with an unhandled exception if it
decides to create a directory and then someone else gets there first.

Diff Detail

Event Timeline

brooks created this revision.May 6 2018, 9:37 AM
brooks added a comment.May 6 2018, 9:40 AM

I've received multiple reports of this issue from FreeBSD ports users, but have never encountered it myself. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227460

brooks updated this revision to Diff 145401.May 6 2018, 9:42 AM
  • Correct whitespace.

For the record, this has been fixed upstream: https://github.com/sphinx-doc/sphinx/pull/4282. However, I don't know which release version (if any) has the fix.