This is an archive of the discontinued LLVM Phabricator instance.

[HIP] Set proper triple and offload kind for the toolchain

Authored by yaxunl on May 4 2018, 2:14 PM.

Diff Detail


Event Timeline

yaxunl created this revision.May 4 2018, 2:14 PM
rjmccall added inline comments.May 4 2018, 9:03 PM
554 ↗(On Diff #145293)

It seems to me that it wouldn't be too hard to do your TODO here; it's basically just checking for HIP (and remembering that you saw it) in the any_of function, right?

yaxunl updated this revision to Diff 145699.May 8 2018, 8:53 AM
yaxunl marked an inline comment as done.

Revised by John's comments.

rjmccall accepted this revision.May 8 2018, 1:18 PM

Thanks, LGTM.

This revision is now accepted and ready to land.May 8 2018, 1:18 PM
This revision was automatically updated to reflect the committed changes.