Oenmp task with by reference array

[zahiraam]

[rsmith]

lib/CodeGen/CGExprAgg.cpp

1624–1625

EmitAggExpr should only be called on expressions with aggregate evaluation kind. Whatever issue is being uncovered by your testcase should almost certainly be fixed in a caller of this function, not here.

[zahiraam]

Is this better? Thanks.

lib/CodeGen/CGExprAgg.cpp

 
 
 
 /// EmitAggExpr - Emit the computation of the specified expression of aggregate
 /// type.  The result is computed into DestPtr.  Note that if DestPtr is null,
 /// the value of the aggregate expression is not needed.  If VolatileDest is
 /// true, DestPtr cannot be 0.
 void CodeGenFunction::EmitAggExpr(const Expr *E, AggValueSlot Slot) {
-  assert(E && hasAggregateEvaluationKind(E->getType()) &&
+  assert( E && (hasAggregateEvaluationKind(E->getType()) ||
+                hasScalarEvaluationKind(E->getType())) &&
          "Invalid aggregate expression to emit");
   assert((Slot.getAddress().isValid() || Slot.isIgnored()) &&
          "slot has bits but no address");
 
   // Optimize the slot if possible.
   CheckAggExprForMemSetUse(Slot, E, *this);
  
   AggExprEmitter(*this, Slot, Slot.isIgnored()).Visit(const_cast<Expr*>(E));

test/OpenMP/task_by_reference.cpp

+// RUN: %clang_cc1 -verify -fopenmp -o - %s
+//expected-no-diagnostics
+
+extern int printf(const char *, ...);
+void traverse(int (&p)[5], int N) {
+  if (N < 5) {
+#pragma omp task
+    {
+      traverse(p, N + 1);
+    }
+    printf("%d\n", p[N]);
+  }
+}
+
+int main() {
+  int root[5] = {1, 2, 3, 4, 5};
+
+#pragma omp parallel
+  {
+#pragma omp single
+    {
+      traverse(root, 0);
+    }
+  }
+  printf("PASSED\n");
+}