This is an archive of the discontinued LLVM Phabricator instance.

[DAGCombiner] Change the SDLoc on split extloads (2/N)
ClosedPublic

Authored by vsk on Apr 26 2018, 5:06 PM.

Details

Summary

In DAGCombiner, we try to simplify this pattern:

([s|z]ext (load ...))

Conceptually, a new extload which is created while splitting the load
should have the same debug location as the load.

Making this change affects the IROrder of the new load, causing some
test case churn.

In practice, the new location never appears to be different from the
location of the [s|z]ext, at least not during check-llvm or a stage2
build.

Part of: llvm.org/PR37262

Diff Detail

Repository
rL LLVM

Event Timeline

vsk created this revision.Apr 26 2018, 5:06 PM
niravd accepted this revision.Apr 26 2018, 6:46 PM

LGTM.

This revision is now accepted and ready to land.Apr 26 2018, 6:46 PM
This revision was automatically updated to reflect the committed changes.