Page MenuHomePhabricator

Enable EliminateAvailableExternally pass for -O1
ClosedPublic

Authored by vlad.tsyrklevich on Apr 25 2018, 4:10 PM.

Details

Summary

Follow-up to D43690, the EliminateAvailableExternally pass currently
runs under -O0 and -O2 and up. Under -O1 we would still want to drop
available_externally symbols to reduce space without inlining having
run.

Diff Detail

Repository
rL LLVM

Event Timeline

test/Other/opt-O1-pipeline.ll
166 ↗(On Diff #144034)

Highlighting the relevant portion of this test.

tejohnson accepted this revision.Apr 25 2018, 4:43 PM

LGTM

I just checked the new PM and it does seem to run this already at O1 (at least, by visual inspection of the code it appears to). OTOH the new PM doesn't appear to run any opt passes at -O0, so that's a bit different than what is happening in the old PM, but that is a separate issue.

This revision is now accepted and ready to land.Apr 25 2018, 4:43 PM
This revision was automatically updated to reflect the committed changes.