Page MenuHomePhabricator

[ELF] - Never use std::sort.
ClosedPublic

Authored by grimar on Apr 23 2018, 8:18 AM.

Details

Summary

It turns out we should not use the std::sort anymore.
r327219 added a new wrapper llvm::sort (D39245).
When EXPENSIVE_CHECKS is defined, it shuffles the
input container and that helps to find non-deterministic
ordering.

Patch changes code to use llvm::sort and std::stable_sort
instead of std::sort

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

grimar created this revision.Apr 23 2018, 8:18 AM
This revision is now accepted and ready to land.Apr 23 2018, 8:22 PM
Closed by commit rLLD330702: [ELF] - Never use std::sort. (authored by grimar, committed by ). · Explain WhyApr 24 2018, 2:58 AM
This revision was automatically updated to reflect the committed changes.