This is an archive of the discontinued LLVM Phabricator instance.

Paths

Remove impossible _MSC_VER check
ClosedPublic

Authored by rnk on Apr 19 2018, 11:39 AM.

Reviewers

EricWF
smeenai

Commits

Summary

It is immediately preceded by this check:

#if _MSC_VER < 1900
#error "MSVC versions prior to Visual Studio 2015 are not supported"
#endif

LGTM. I'd tried to clean all stale _MSC_VER conditionals in the past, but I must have missed some.

This revision is now accepted and ready to land.Apr 19 2018, 12:38 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

libcxx/

trunk/

include/

3 lines

	Show First 20 Lines • Show All 580 Lines • ▼ Show 20 Lines
	#if _MSC_VER < 1900			#if _MSC_VER < 1900
	#error "MSVC versions prior to Visual Studio 2015 are not supported"			#error "MSVC versions prior to Visual Studio 2015 are not supported"
	#endif			#endif

	#define _LIBCPP_HAS_IS_BASE_OF			#define _LIBCPP_HAS_IS_BASE_OF
	#define _LIBCPP_HAS_NO_CONSTEXPR			#define _LIBCPP_HAS_NO_CONSTEXPR
	#define _LIBCPP_HAS_NO_CXX14_CONSTEXPR			#define _LIBCPP_HAS_NO_CXX14_CONSTEXPR
	#define _LIBCPP_HAS_NO_VARIABLE_TEMPLATES			#define _LIBCPP_HAS_NO_VARIABLE_TEMPLATES
	#if _MSC_VER <= 1800
	#define _LIBCPP_HAS_NO_UNICODE_CHARS
	#endif
	#define _LIBCPP_HAS_NO_NOEXCEPT			#define _LIBCPP_HAS_NO_NOEXCEPT
	#define __alignof__ __alignof			#define __alignof__ __alignof
	#define _LIBCPP_NORETURN __declspec(noreturn)			#define _LIBCPP_NORETURN __declspec(noreturn)
	#define _ALIGNAS(x) __declspec(align(x))			#define _ALIGNAS(x) __declspec(align(x))
	#define _ALIGNAS_TYPE(x) alignas(x)			#define _ALIGNAS_TYPE(x) alignas(x)
	#define _LIBCPP_HAS_NO_VARIADICS			#define _LIBCPP_HAS_NO_VARIADICS

	#define _LIBCPP_BEGIN_NAMESPACE_STD namespace std {			#define _LIBCPP_BEGIN_NAMESPACE_STD namespace std {
	▲ Show 20 Lines • Show All 729 Lines • Show Last 20 Lines