This is an archive of the discontinued LLVM Phabricator instance.

Add tests for shrink wrapping and VLAs
ClosedPublic

Authored by chill on Apr 17 2018, 10:23 AM.

Details

Summary

Split the test from https://reviews.llvm.org/D45524 and move it to the relevant target directories.

Diff Detail

Event Timeline

chill created this revision.Apr 17 2018, 10:23 AM

Sorry for not looking thoroughly at the test in the previous patch.

test/CodeGen/AArch64/shrink-wrapping-vla.ll
17

Hmm, I'm pretty sure this is not needed. Did you encounter any issues without this line? My understanding was that the test failed because it lived in Generic instead of the target directory.

19

Related to both tests: are these attributes actually needed? (the #0, #1)

chill updated this revision to Diff 142904.Apr 18 2018, 3:51 AM
chill edited the summary of this revision. (Show Details)
chill marked 2 inline comments as done.
thegameg accepted this revision.Apr 18 2018, 6:08 AM

local_unnamed_addr is probably not needed either.

Thanks! LGTM. You can just remove the local_unnamed_addrs and commit this.

This revision is now accepted and ready to land.Apr 18 2018, 6:08 AM
chill updated this revision to Diff 142926.Apr 18 2018, 6:37 AM
This revision was automatically updated to reflect the committed changes.