This is an archive of the discontinued LLVM Phabricator instance.

Differential D45570

[XRay] [clang] use compiler-rt's symbol visibility rules
Needs ReviewPublic

Authored by pelikan on Apr 12 2018, 7:24 AM.

Details

Reviewers
dberris
Summary

Depends on D38993.

Diff Detail

Event Timeline

pelikan created this revision.Apr 12 2018, 7:24 AM
Harbormaster completed remote builds in B17015: Diff 142173.Apr 12 2018, 7:25 AM
pelikan updated this revision to Diff 142174.Apr 12 2018, 7:27 AM

while there, clang-format the code I touched

Harbormaster completed remote builds in B17016: Diff 142174.Apr 12 2018, 7:27 AM

Revision Contents

PathSize
lib/
Driver/
ToolChains/
10 lines

Diff 142174

lib/Driver/ToolChains/CommonArgs.cpp

Show First 20 Lines • Show All 700 Lines • ▼ Show 20 Linesbool tools::addSanitizerRuntimes(const ToolChain &TC, const ArgList &Args,
const SanitizerArgs &SanArgs = TC.getSanitizerArgs(); const SanitizerArgs &SanArgs = TC.getSanitizerArgs();
if (SanArgs.hasCrossDsoCfi() && !AddExportDynamic) if (SanArgs.hasCrossDsoCfi() && !AddExportDynamic)
CmdArgs.push_back("-export-dynamic-symbol=__cfi_check"); CmdArgs.push_back("-export-dynamic-symbol=__cfi_check");
return !StaticRuntimes.empty() || !NonWholeStaticRuntimes.empty(); return !StaticRuntimes.empty() || !NonWholeStaticRuntimes.empty();
} }
bool tools::addXRayRuntime(const ToolChain&TC, const ArgList &Args, ArgStringList &CmdArgs) { bool tools::addXRayRuntime(const ToolChain &TC, const ArgList &Args,
if (Args.hasArg(options::OPT_shared)) ArgStringList &CmdArgs) {
return false; if (Args.hasArg(options::OPT_shared)) return false;
if (TC.getXRayArgs().needsXRayRt()) { if (TC.getXRayArgs().needsXRayRt()) {
CmdArgs.push_back("-whole-archive"); CmdArgs.push_back("-whole-archive");
CmdArgs.push_back(TC.getCompilerRTArgString(Args, "xray", false)); CmdArgs.push_back(TC.getCompilerRTArgString(Args, "xray", false));
for (const auto &Mode : TC.getXRayArgs().modeList()) for (const auto &Mode : TC.getXRayArgs().modeList())
CmdArgs.push_back(TC.getCompilerRTArgString(Args, Mode, false)); CmdArgs.push_back(TC.getCompilerRTArgString(Args, Mode, false));
CmdArgs.push_back("-no-whole-archive"); CmdArgs.push_back("-no-whole-archive");
SmallString<128> XRay(TC.getCompilerRT(Args, "xray"));
CmdArgs.push_back(Args.MakeArgString("--dynamic-list=" + XRay + ".syms"));
CmdArgs.push_back(Args.MakeArgString("--version-script=" + XRay + ".vers"));
return true; return true;
} }
return false; return false;
} }
void tools::linkXRayRuntimeDeps(const ToolChain &TC, ArgStringList &CmdArgs) { void tools::linkXRayRuntimeDeps(const ToolChain &TC, ArgStringList &CmdArgs) {
CmdArgs.push_back("--no-as-needed"); CmdArgs.push_back("--no-as-needed");
▲ Show 20 Lines • Show All 504 Lines • Show Last 20 Lines