Our code for LazyObject and LazyArchive duplicates.
This patch extracts the common part to remove
the duplication.
Differential D45516
[ELF] - Refactor lazy symbol duplicated code. grimar on Apr 11 2018, 5:51 AM. Authored by
Details Our code for LazyObject and LazyArchive duplicates. This patch extracts the common part to remove
Diff Detail
Event TimelineComment Actions Isn't it more complicated than before? I understand that it is tempting, but generally speaking, I try to *not* abstract things unless doing it is a clear win. I'm a bit worried the direction of your recent "refactoring" patches as it adds more abstractions for a (in my opinion) marginal benefits. Factoring out common code is not always a win in terms of readability, especially when it involves callback functions and such. Simple, repeated code is sometimes better, and the original code was written with that in mind. I really prefer boring code over clever code that uses higher order functions. Comment Actions
What do you think about this version, Rui? Is it still too much?
|