This is an archive of the discontinued LLVM Phabricator instance.

Differential D45312

[X86] Introduce LLVM wbinvd intrinsic
ClosedPublic

Authored by GBuella on Apr 5 2018, 2:04 AM.

Details

Reviewers
craig.topper
echristo
Commits
rG297c1387983d: [X86] Introduce LLVM wbinvd intrinsic
rL329936: [X86] Introduce LLVM wbinvd intrinsic
Summary

A previously missing intrinsic for an old instruction.

Diff Detail

Event Timeline

GBuella created this revision.Apr 5 2018, 2:04 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 5 2018, 2:04 AM
GBuella added a comment.Apr 5 2018, 2:04 AM

The reason is, the _wbinvd intrinsic, and builtin were just recently introduced in GCC.

craig.topper accepted this revision.Apr 7 2018, 1:29 PM

LGTM

This revision is now accepted and ready to land.Apr 7 2018, 1:29 PM
GBuella updated this revision to Diff 142141.Apr 12 2018, 3:37 AM

Rebased the patch.

GBuella retitled this revision from Introduce LLVM wbinvd intrinsic to [X86] Introduce LLVM wbinvd intrinsic.Apr 12 2018, 3:37 AM
Closed by commit rL329936: [X86] Introduce LLVM wbinvd intrinsic (authored by GBuella). · Explain WhyApr 12 2018, 11:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
llvm/
IR/
7 lines
lib/
Target/
X86/
3 lines
test/
CodeGen/
X86/
19 lines

Diff 141116

include/llvm/IR/IntrinsicsX86.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 6,415 Lines • ▼ Show 20 Lines
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Cache-line zero // Cache-line zero
let TargetPrefix = "x86" in { let TargetPrefix = "x86" in {
def int_x86_clzero : GCCBuiltin<"__builtin_ia32_clzero">, def int_x86_clzero : GCCBuiltin<"__builtin_ia32_clzero">,
Intrinsic<[], [llvm_ptr_ty], []>; Intrinsic<[], [llvm_ptr_ty], []>;
} }
//===----------------------------------------------------------------------===//
// Cache write back intrinsics
let TargetPrefix = "x86" in {
def int_x86_wbinvd : GCCBuiltin<"__builtin_ia32_wbinvd">,
Intrinsic<[], [], []>;
}

lib/Target/X86/X86InstrSystem.td

Show First 20 Lines • Show All 475 Lines • ▼ Show 20 Lines
let Defs = [EAX, EBX, ECX, EDX], Uses = [EAX, ECX] in let Defs = [EAX, EBX, ECX, EDX], Uses = [EAX, ECX] in
def CPUID : I<0xA2, RawFrm, (outs), (ins), "cpuid", [], IIC_CPUID>, TB; def CPUID : I<0xA2, RawFrm, (outs), (ins), "cpuid", [], IIC_CPUID>, TB;
} // SchedRW } // SchedRW
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Cache instructions // Cache instructions
let SchedRW = [WriteSystem] in { let SchedRW = [WriteSystem] in {
def INVD : I<0x08, RawFrm, (outs), (ins), "invd", [], IIC_INVD>, TB; def INVD : I<0x08, RawFrm, (outs), (ins), "invd", [], IIC_INVD>, TB;
def WBINVD : I<0x09, RawFrm, (outs), (ins), "wbinvd", [], IIC_INVD>, TB; def WBINVD : I<0x09, RawFrm, (outs), (ins), "wbinvd",
[(int_x86_wbinvd)], IIC_INVD>, TB;
} // SchedRW } // SchedRW
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// CET instructions // CET instructions
let SchedRW = [WriteSystem], Predicates = [HasSHSTK] in{ let SchedRW = [WriteSystem], Predicates = [HasSHSTK] in{
let Uses = [SSP] in { let Uses = [SSP] in {
let Defs = [SSP] in { let Defs = [SSP] in {
def INCSSPD : I<0xAE, MRM5r, (outs), (ins GR32:$src), "incsspd\t$src", def INCSSPD : I<0xAE, MRM5r, (outs), (ins GR32:$src), "incsspd\t$src",
▲ Show 20 Lines • Show All 244 Lines • Show Last 20 Lines

test/CodeGen/X86/wbinvd-intrinsic.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -mtriple=i686-unknown-unknown | FileCheck %s --check-prefix=i686
; RUN: llc < %s -mtriple=x86_64-unknown-unknown | FileCheck %s --check-prefix=x86_64
define void @test_wbinvd() {
; i686-LABEL: test_wbinvd:
; i686: # %bb.0:
; i686-NEXT: wbinvd
; i686-NEXT: retl
;
; x86_64-LABEL: test_wbinvd:
; x86_64: # %bb.0:
; x86_64-NEXT: wbinvd
; x86_64-NEXT: retq
call void @llvm.x86.wbinvd()
ret void
}
declare void @llvm.x86.wbinvd()