[Polly] abort() on assertion violation.

[Meinersbur]

Summary

Before this patch, ISL_ASSERT only printed an error message to stderr. This can be easily missed if the program continues or just fails later. To fail-early and help error diagnostics (e.g. using bugpoint), call abort() when an assertion does not hold.

I seem to just have forgotten to add this abort() when I originally proposed the ISL_ASSERT macro.

Suggested-By: Eli Friedman <[e-mail]>

[Meinersbur]

We might also think about using the standard assert() macro instead.

[philip.pfaffe]

In D45171#1054536, @Meinersbur wrote:

We might also think about using the standard assert() macro instead.

+1, but this should be a follow-up change.

Other than that, LGTM.

lib/External/isl/include/isl/isl-noexceptions.h

 
 #define ISLPP_ASSERT(test, message)                          \
   do {                                                       \
     if (test)                                                \
       break;                                                 \
     fputs("Assertion \"" #test "\" failed at " __FILE__      \
       ":" ISLPP_STRINGIZE(__LINE__) "\n  " message "\n",     \
       stderr);                                               \
+    abort();                                                 \
   } while (0)
 
 class boolean {
 private:
   isl_bool val;
 
   friend isl::boolean manage(isl_bool val);
   boolean(isl_bool val): val(val) {}