Page MenuHomePhabricator

[coroutines] Add support for llvm.coro.noop intrinsics
ClosedPublic

Authored by GorNishanov on Mar 30 2018, 4:03 PM.

Details

Summary

A recent addition to Coroutines TS (https://wg21.link/p0913) adds a pre-defined coroutine noop_coroutine that does nothing.
To implement this feature, we implemented an llvm.coro.noop intrinsic that returns a coroutine handle to a coroutine that does nothing when resumed or destroyed.

Diff Detail

Repository
rL LLVM

Event Timeline

GorNishanov created this revision.Mar 30 2018, 4:03 PM

added a test that verifies lowering of llvm.coro.noop

modocache accepted this revision.Apr 1 2018, 3:14 PM

Thanks!

docs/Coroutines.rst
907 ↗(On Diff #140534)

A nit-pick, but I would use two sentences here: "...private constant coroutine frame. The resume and destroy handlers for this frame are empty functions that do nothing."

This revision is now accepted and ready to land.Apr 1 2018, 3:14 PM
This revision was automatically updated to reflect the committed changes.