This is an archive of the discontinued LLVM Phabricator instance.

Differential D44936

TableGen: More helpful error messages
ClosedPublic

Authored by nhaehnle on Mar 27 2018, 8:28 AM.

Details

Reviewers
arsenm
rampitec
b-sumner
Commits
rG24e3a4d6e93c: TableGen: More helpful error messages
rL328936: TableGen: More helpful error messages
Summary

Change-Id: I3c23f6f6597912423762780cd8c5315870412bbe

Diff Detail

Event Timeline

nhaehnle created this revision.Mar 27 2018, 8:28 AM
Herald added a subscriber: wdng. · View Herald TranscriptMar 27 2018, 8:28 AM
nhaehnle added a child revision: D44937: AMDGPU: Make getTgtMemIntrinsic table-driven for resource-based intrinsics.Mar 27 2018, 8:29 AM
nhaehnle added a parent revision: D44935: TableGen: Support Intrinsic values in SearchableTable.Mar 27 2018, 8:40 AM
arsenm accepted this revision.Mar 27 2018, 9:49 AM

LGTM

This revision is now accepted and ready to land.Mar 27 2018, 9:49 AM
Closed by commit rL328936: TableGen: More helpful error messages (authored by nha). · Explain WhyApr 1 2018, 10:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
utils/
TableGen/
8 lines

Diff 139937

utils/TableGen/CodeGenTarget.cpp

Show First 20 Lines • Show All 609 Lines • ▼ Show 20 LinesCodeGenIntrinsic::CodeGenIntrinsic(Record *R) {
// Parse the list of parameter types. // Parse the list of parameter types.
TypeList = R->getValueAsListInit("ParamTypes"); TypeList = R->getValueAsListInit("ParamTypes");
for (unsigned i = 0, e = TypeList->size(); i != e; ++i) { for (unsigned i = 0, e = TypeList->size(); i != e; ++i) {
Record *TyEl = TypeList->getElementAsRecord(i); Record *TyEl = TypeList->getElementAsRecord(i);
assert(TyEl->isSubClassOf("LLVMType") && "Expected a type!"); assert(TyEl->isSubClassOf("LLVMType") && "Expected a type!");
MVT::SimpleValueType VT; MVT::SimpleValueType VT;
if (TyEl->isSubClassOf("LLVMMatchType")) { if (TyEl->isSubClassOf("LLVMMatchType")) {
unsigned MatchTy = TyEl->getValueAsInt("Number"); unsigned MatchTy = TyEl->getValueAsInt("Number");
assert(MatchTy < OverloadedVTs.size() && if (MatchTy >= OverloadedVTs.size()) {
"Invalid matching number!"); PrintError(R->getLoc(),
"Parameter #" + Twine(i) + " has out of bounds matching "
"number " + Twine(MatchTy));
PrintFatalError(Twine("ParamTypes is ") + TypeList->getAsString());
}
VT = OverloadedVTs[MatchTy]; VT = OverloadedVTs[MatchTy];
// It only makes sense to use the extended and truncated vector element // It only makes sense to use the extended and truncated vector element
// variants with iAny types; otherwise, if the intrinsic is not // variants with iAny types; otherwise, if the intrinsic is not
// overloaded, all the types can be specified directly. // overloaded, all the types can be specified directly.
assert(((!TyEl->isSubClassOf("LLVMExtendedType") && assert(((!TyEl->isSubClassOf("LLVMExtendedType") &&
!TyEl->isSubClassOf("LLVMTruncatedType") && !TyEl->isSubClassOf("LLVMTruncatedType") &&
!TyEl->isSubClassOf("LLVMVectorSameWidth")) || !TyEl->isSubClassOf("LLVMVectorSameWidth")) ||
VT == MVT::iAny || VT == MVT::vAny) && VT == MVT::iAny || VT == MVT::vAny) &&
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines