This is an archive of the discontinued LLVM Phabricator instance.

Enable msan unconditionally on Linux

Authored by vit9696 on Mar 27 2018, 6:32 AM.



Memeory sanitizer compatibility are already done in MemorySanitizer::doInitialization. It verifies whether the necessary offsets exist and bails out if not. For this reason it is no good to duplicate two checks in two projects. This patch removes clang check and postpones msan compatibility validation till MemorySanitizer::doInitialization.

Another reason for this patch is to allow using msan with any CPU (given compatible runtime) and custom mapping provided via the arguments added by

Diff Detail


Event Timeline

vit9696 created this revision.Mar 27 2018, 6:32 AM
eugenis added a subscriber: kcc.Mar 27 2018, 1:26 PM

I too find these checks arbitrary and pointless. @kcc ?

Now that was merged upstream, may I request this to be merged as well?
As stated above it is pretty much pointless to have the check doubled, and after more than a week nobody thought of any issue.
Thanks :)

This revision was not accepted when it landed; it landed in state Needs Review.Apr 4 2018, 4:50 PM
This revision was automatically updated to reflect the committed changes.

Merged. Please don't forget to update tests next time.