Page MenuHomePhabricator

[ELF] Disable ICF for synthetic sections
ClosedPublic

Authored by andrewng on Mar 27 2018, 6:03 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

andrewng created this revision.Mar 27 2018, 6:03 AM
ruiu added inline comments.Mar 27 2018, 6:20 AM
ELF/ICF.cpp
166 ↗(On Diff #139906)

Please explain why. We don't merge synthetic sections because their Data member doesn't have a meaningful value.

168 ↗(On Diff #139906)

Maybe it's better to write this as two if's because the boolean expression is a bit too complicated.

andrewng updated this revision to Diff 139914.Mar 27 2018, 6:49 AM

Updated to address review comments.

ruiu accepted this revision.Mar 27 2018, 6:51 AM

LGTM

Thanks!

ELF/ICF.cpp
173 ↗(On Diff #139914)

You can use isa instead of dyn_cast.

This revision is now accepted and ready to land.Mar 27 2018, 6:51 AM
Closed by commit rL328624: [ELF] Disable ICF for synthetic sections (authored by anng, committed by ). · Explain WhyMar 27 2018, 7:13 AM
This revision was automatically updated to reflect the committed changes.