Implement TypeAndOrName::TypeAndOrName(const CompilerType &)

[tromey]

Summary

I noticed that the TypeAndOrName(const CompilerType &) constructor is
declared, but never defined. This patch implements it.

[clayborg]

Should this be removed then? If not one was using it, we should remove it from the header file.

[davide]

Just remove it I'd say (bonus point if you can remove other bits)

[tromey]

I only found this because I tried to use it in my rust plugin. So, I would rather implement it, because if I removed it, I would have to find a new way to do this.

[clayborg]

Can you add this to the patch for the rust plug-in then?

[tromey]

In D44752#1052027, @clayborg wrote:

Can you add this to the patch for the rust plug-in then?

Yes, I already did; I just thought that since it was a latent bug in upstream that I would submit it separately.

[clayborg]

We probably need a test then.

source/Symbol/Type.cpp

TypeAndOrName::TypeAndOrName(const char *in_type_str)
     : m_type_name(in_type_str) {}
 
 TypeAndOrName::TypeAndOrName(const TypeAndOrName &rhs)
     : m_type_pair(rhs.m_type_pair), m_type_name(rhs.m_type_name) {}
 
 TypeAndOrName::TypeAndOrName(ConstString &in_type_const_string)
     : m_type_name(in_type_const_string) {}
 
+TypeAndOrName::TypeAndOrName(const CompilerType &type)
+    : m_type_pair(type)
+{
+  if (m_type_pair)
+    m_type_name = m_type_pair.GetName();
+}
+
 TypeAndOrName &TypeAndOrName::operator=(const TypeAndOrName &rhs) {
   if (this != &rhs) {
     m_type_name = rhs.m_type_name;
     m_type_pair = rhs.m_type_pair;
   }
   return *this;
 }