Page MenuHomePhabricator

Implement TypeAndOrName::TypeAndOrName(const CompilerType &)
Needs RevisionPublic

Authored by tromey on Mar 21 2018, 12:50 PM.

Details

Reviewers
clayborg
Summary

I noticed that the TypeAndOrName(const CompilerType &) constructor is
declared, but never defined. This patch implements it.

Event Timeline

tromey created this revision.Mar 21 2018, 12:50 PM

Should this be removed then? If not one was using it, we should remove it from the header file.

davide added a subscriber: davide.Mar 29 2018, 9:25 AM

Just remove it I'd say (bonus point if you can remove other bits)

I only found this because I tried to use it in my rust plugin. So, I would rather implement it, because if I removed it, I would have to find a new way to do this.

Can you add this to the patch for the rust plug-in then?

Can you add this to the patch for the rust plug-in then?

Yes, I already did; I just thought that since it was a latent bug in upstream that I would submit it separately.

clayborg requested changes to this revision.Mar 29 2018, 10:52 AM

We probably need a test then.

This revision now requires changes to proceed.Mar 29 2018, 10:52 AM