Replace calls to 'system' with an error message and abort.

[mzolotukhin]

Summary

'system' is unavailable on iOS, which causes build failures. These
execution paths are probably never taken anyway (if we hit the abort,
then we'll need to revert this and disable it only on certain
platforms.)

[mzolotukhin]

Ping!

[mzolotukhin]

Ping!

[cmatthews]

LGTM.

This code is obviously dead.

MultiSource/Applications/lua/loslib.c

else {
     lua_pushfstring(L, "%s: %s", filename, strerror(en));
     lua_pushinteger(L, en);
     return 3;
   }
 }
 
 
 static int os_execute (lua_State *L) {
-  lua_pushinteger(L, system(luaL_optstring(L, 1, NULL)));
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+//   lua_pushinteger(L, system(luaL_optstring(L, 1, NULL)));
   return 1;
 }
 
 
 static int os_remove (lua_State *L) {
   const char *filename = luaL_checkstring(L, 1);
   return os_pushresult(L, remove(filename) == 0, filename);
 }

MultiSource/Applications/siod/slibu.c

  strcpy(r,in);
  return(r);}
 #endif
 
 LISP lsystem(LISP args)
 {int retval;
  long iflag;
  iflag = no_interrupt(1);
- retval = system(get_c_string(string_append(args)));
+ fprintf(stderr, "Cannot execute system calls!\n");
+ abort();
+ retval = 0;
+//  retval = system(get_c_string(string_append(args)));
  no_interrupt(iflag);
  if (retval < 0)
    return(cons(flocons(retval),llast_c_errmsg(-1)));
  else
    return(flocons(retval));}
 
 #ifndef WIN32
 LISP lgetuid(void)

MultiSource/Benchmarks/DOE-ProxyApps-C++/HPCCG/CMakeLists.txt

 set(PROG HPCCG)
+list(APPEND CXXFLAGS -DREDSTORM) # -DREDSTORM for mkdir
 list(APPEND LDFLAGS -lm)
 set(RUN_OPTIONS 50 50 50)
 llvm_multisource()

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/CMakeLists.txt

 set(PROG miniFE)
-list(APPEND CXXFLAGS -I. -DMINIFE_SCALAR=double  -DMINIFE_LOCAL_ORDINAL=int -DMINIFE_GLOBAL_ORDINAL=int -DMINIFE_CSR_MATRIX)
+list(APPEND CXXFLAGS -I. -DMINIFE_SCALAR=double  -DMINIFE_LOCAL_ORDINAL=int -DMINIFE_GLOBAL_ORDINAL=int -DMINIFE_CSR_MATRIX -DREDSTORM) # -DREDSTORM for mkdir
 list(APPEND LDFLAGS -lm)
 set(RUN_OPTIONS -nx 64 -ny 64 -nz 64)
 llvm_multisource()

MultiSource/Benchmarks/MiBench/consumer-typeset/z03.c

if( i < MAX_COMPRESSED )
       if( SafeExecution )
       {
         Error(3, 17, "safe execution prohibiting command: %s", WARN, xfpos,buff);
         *compressed = FALSE;
         fp = null;
       }
       else
       {
-        system(buff);
+        fprintf(stderr, "Cannot execute system calls!\n");
+        abort();
+//         system(buff);
         fp = fopen(LOUT_EPS, READ_TEXT);
         *compressed = TRUE;
       }
     }
     else *compressed = FALSE;
   }
 
   debug2(DFS, DD, "OpenIncGraphicFile returning (fp %s null, *full_name = %s)",

MultiSource/Benchmarks/MiBench/consumer-typeset/z40.c

if( SafeExecution )
     /* if safe execution, print error message and return empty object */
     Error(40, 2, "safe execution prohibiting command: %s", WARN, &fpos(x),
       command);
     res = MakeWord(WORD, STR_EMPTY, &fpos(x));
   }
   else
   {
     /* execute the command, echo error messages, and exit if status problem */
-    status = system( (char *) command);
+    fprintf(stderr, "Cannot execute system calls!\n");
+    abort();
+    status = 0;
+//     status = system( (char *) command);
     err_fp = StringFOpen(FILTER_ERR, READ_TEXT);
     if( err_fp != NULL )
     { while( fgets(line, MAX_LINE, err_fp) != NULL )
       { if( line[strlen(line)-1] == '\n' )
     line[strlen(line)-1] = '\0';
         Error(40, 3, "%s", WARN, &fpos(x), line);
       }
       fclose(err_fp);

MultiSource/Benchmarks/Prolangs-C/TimberWolfMC/finalout.c

 
 if( doCompaction > 0 ) {
     finalShot = 1 ;
     gmain() ;
     rmain() ;
     redoFlag = 0 ;
     addpins() ;
 
+    fprintf(stderr, "Cannot execute system calls!\n");
+    abort();
     sprintf( command , "cp %s.cfs cfss1", cktName ) ;
-    system( command ) ;
+//     system( command ) ;
     sprintf( command , "cp %s.cfb cfbb1", cktName ) ;
-    system( command ) ;
+//     system( command ) ;
 
     for( c = 1 ; c <= doCompaction ; c++ ) {
 
   finalShot = c ;
   if( c == doCompaction ) {
       lapFactor *= 2.0 ;
       offset = (int)( 4.0 / lapFactor ) ;
       fprintf(fpo,"\n\nNew Value for lapFactor: %f\n", lapFactor );
//     system( command ) ;
   fprintf(fpo,"\n\nCOMPACT #%d: TOTAL Wire Length:\n", c );
   fprintf(fpo,"(after) WITH Pads: %d    WITHOUT Pads: %d\n\n",
           withPads , withOutPads ) ;
 
   gmain() ;
   rmain() ;
   redoFlag = 0 ;
 
+        fprintf(stderr, "Cannot execute system calls!\n");
+        abort();
   sprintf( command , "cp %s.cfs cfss%d", cktName , c + 1) ;
-  system( command ) ;
+//  system( command ) ;
   sprintf( command , "cp %s.cfb cfbb%d", cktName , c + 1) ;
-  system( command ) ;
+//  system( command ) ;
     }
     subpins() ;
     fprintf(fpo,"\n\nCORE Bounding Box: l:%d r:%d b:%d t:%d\n\n",
           bbleft , bbright , bbbottom , bbtop ) ;
 } else {
     if( doChannelGraph ) {
   gmain() ;
     }

MultiSource/Benchmarks/Prolangs-C/assembler/assem.c

/* --------------------------------- Get name for OBJECT FILE               */
       PASS2(INPUT_STREAM,OBJECT_STREAM,LISTING_STREAM,&SYM_TAB,&ERROR);
 
       (void) fclose(OBJECT_STREAM);
       (void) fclose(LISTING_STREAM);
       (void) fclose(INPUT_STREAM);
 
 /* -------------------------------- Delete the temporary output file        */
       if (!DEBUG_FLAG_1) {
-  char *TEMP;
-  TEMP = (char *) malloc((unsigned int) 
-             (4+strlen(TEMP_OUTPUT_FILE_NAME)));
-  (void) sprintf(TEMP,"rm %s",TEMP_OUTPUT_FILE_NAME);
-  (void) system(TEMP);
+        (void) remove(TEMP_OUTPUT_FILE_NAME);
       }
 
 /* -------------------------------- If errors, delete the object file       */
       if (ERROR) {
-  char *TEMP;
-  TEMP = (char *) malloc((unsigned int) 
-             (4+strlen(OBJECT_FILE)));
-  (void) sprintf(TEMP,"rm %s",OBJECT_FILE); 
-  (void) system(TEMP); 
+        (void) remove(OBJECT_FILE);
   (void) printf("Errors detected. Deleted object file.\n");
       }
     }
   }
   return 0;
 }

MultiSource/Benchmarks/mafft/pairlocalalign.c

static void callfoldalign( int nseq, char **mseq )
   for( i=0; i<nseq; i++ )
   {
     fprintf( fp, ">%d\n", i+1 );
     fprintf( fp, "%s\n", mseq[i] );
   }
   fclose( fp );
 
   sprintf( com, "env PATH=%s  foldalign210 %s _foldalignin > _foldalignout ", whereispairalign, foldalignopt );
-  res = system( com );
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+  res = 0;
+//  res = system( com );
   if( res )
   {
     fprintf( stderr, "Error in foldalign\n" );
     exit( 1 );
   }
 
 }
 
for( i=0; i<nseq; i++ )
     fprintf( fp, ">%d\n", i+1 );
     fprintf( fp, "%s\n", mseq[i] );
   }
   fclose( fp );
 
 
 //  fprintf( stderr, "calling LaRA\n" );
   sprintf( com, "env PATH=%s:/bin:/usr/bin mafft_lara -i _larain -w _laraout -o _lara.params %s", whereispairalign, laraarg );
-  res = system( com );
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+  res = 0;
+//  res = system( com );
   if( res )
   {
     fprintf( stderr, "Error in lara\n" );
     exit( 1 );
   }
 }
 
 static float recalllara( char **mseq1, char **mseq2, int alloclen )
static float callmxscarna_giving_bpp( char **mseq1, char **mseq2, char **bpp1, char **bpp2, int alloclen )
   while( *bpp1 )
     fprintf( fp, *bpp1++ );
 
   fprintf( fp, ">b\n" );
   while( *bpp2 )
     fprintf( fp, *bpp2++ );
   fclose( fp );
 
-  system( "tr -d '\\r' < _bpporg > _bpp" ); // for cygwin, wakaran
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+//  system( "tr -d '\\r' < _bpporg > _bpp" ); // for cygwin, wakaran
 
   t2u( *mseq1 );
   t2u( *mseq2 );
   fp = fopen( "_mxscarnainorg", "w" );
   if( !fp )
   {
     fprintf( stderr, "Cannot open _mxscarnainorg\n" );
     exit( 1 );
   }
   fprintf( fp, ">1\n" );
 //  fprintf( fp, "%s\n", *mseq1 );
   write1seq( fp, *mseq1 );
   fprintf( fp, ">2\n" );
 //  fprintf( fp, "%s\n", *mseq2 );
   write1seq( fp, *mseq2 );
   fclose( fp );
 
-  system( "tr -d '\\r' < _mxscarnainorg > _mxscarnain" ); // for cygwin, wakaran
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+//  system( "tr -d '\\r' < _mxscarnainorg > _mxscarnain" ); // for cygwin, wakaran
 
   sprintf( com, "env PATH=%s mxscarnamod -readbpp _mxscarnain > _mxscarnaout 2>_dum", whereispairalign );
-  res = system( com );
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+  res = 0;
+//  res = system( com );
   if( res )
   {
     fprintf( stderr, "Error in mxscarna\n" );
     exit( 1 );
   }
 
   fp = fopen( "_mxscarnaout", "r" );
   if( !fp )
static float callmxscarna_slow( char **mseq1, char **mseq2, int alloclen )
   }
   fprintf( fp, ">1\n" );
   fprintf( fp, "%s\n", *mseq1 );
   fprintf( fp, ">2\n" );
   fprintf( fp, "%s\n", *mseq2 );
   fclose( fp );
 
   sprintf( com, "env PATH=%s mxscarnamod _mxscarnain > _mxscarnaout 2>_dum", whereispairalign );
-  res = system( com );
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+  res = 0;
+//  res = system( com );
   if( res )
   {
     fprintf( stderr, "Error in mxscarna\n" );
     exit( 1 );
   }
 
   fp = fopen( "_mxscarnaout", "r" );
   if( !fp )

MultiSource/Benchmarks/mafft/rna.c

void rnaalifoldcall( char **seq, int nseq, RNApair **pairprob )
   {
     fprintf( stderr, "Cannot open /tmp/_rnaalifoldin\n" );
     exit( 1 );
   }
   clustalout_pointer( fp, nseq, lgth, seq, name, NULL, NULL, order );
   fclose( fp );
 
   sprintf( cmd, "RNAalifold -p %s", fnamein );
-  system( cmd );
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+//  system( cmd );
 
   fp = fopen( "alifold.out", "r" );
   if( !fp )
   {
     fprintf( stderr, "Cannot open /tmp/_rnaalifoldin\n" );
     exit( 1 );
   }
 
if( prob > 0.0 )
       pairprob[right][pairnum[right]].bestscore = -1.0;
       pairprob[right][pairnum[right]].bestpos = -1;
       fprintf( stderr, "%d-%d, %f\n", left, right, prob );
 #endif
     }
   }
   fclose( fp );
   sprintf( cmd, "rm -f %s", fnamein );
-  system( cmd ); 
+  fprintf(stderr, "Cannot execute system calls!\n");
+  abort();
+//  system( cmd );
 
   for( i=0; i<lgth; i++ )
   {
     if( (right=pairprob[i][0].bestpos) > -1 )
     {
       pairprob[right][0].bestpos = i;
       pairprob[right][0].bestscore = pairprob[i][0].bestscore;
     }