Details
Details
- Reviewers
mclow.lists
Diff Detail
Diff Detail
Event Timeline
Comment Actions
This looks good to me, but you should probably wait for Marshall to take a look. It would be nice if you took care of the nits (fwiw, I hate trailing comments on the ifdefs since they are easy to get out of sync).
include/__locale | ||
---|---|---|
350 | Might be nice to clang-format this line. | |
include/locale | ||
198 | This is no longer very precise (not that it was particularly so before your change). | |
3678 | Update the trailing comment. | |
3693 | Same. | |
src/locale.cpp | ||
35 | Same. |
Might be nice to clang-format this line.