Page MenuHomePhabricator

[CMake] Properly conditionalize installation of lld libraries
ClosedPublic

Authored by davezarzycki on Mar 8 2018, 12:41 PM.

Details

Reviewers
labath
phosek
Summary

In what appears to be a copy-and-paste error, lld currently only install libraries if the lld tools are configured to build.

Instead, lld should allow the libraries to be installed even if if the lld tools are not being built. Additionally, if users want to only install the tools and not the libraries, the LLVM way of doing that is by checking for follow LLVM_INSTALL_TOOLCHAIN_ONLY.

This fixes PR35960.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

davezarzycki created this revision.Mar 8 2018, 12:41 PM
labath accepted this revision.Mar 9 2018, 1:53 AM

Yea, I probably just copied this from the add_lld_tool function without thinking whether it was correct. Anyway, thanks for fixing this.

This revision is now accepted and ready to land.Mar 9 2018, 1:53 AM
davezarzycki closed this revision.Mar 9 2018, 5:13 AM