This is an archive of the discontinued LLVM Phabricator instance.

[MachineScheduler] Dump SUnits before calling SchedImpl->initialize()
ClosedPublic

Authored by jonpa on Mar 5 2018, 6:18 AM.

Details

Summary

This is a NFC simple patch that changes the DEBUG dumping in the MachineScheduler so that the dumping of the built SUnits is done before the SchedImpl->initialize() is called.

This is better on SystemZ, since it has a strategy that does some dumping at the start of the region, and it is not possible to easily read it if it is output above a long list of SU.

Is this OK for everyone?

Diff Detail

Event Timeline

jonpa created this revision.Mar 5 2018, 6:18 AM

I assume no tests are impacted by this. Otherwise, looks LGTM

jonpa added a comment.Mar 5 2018, 7:02 AM

I assume no tests are impacted by this. Otherwise, looks LGTM

Yes, all tests pass unmodified.

javed.absar accepted this revision.Mar 5 2018, 8:18 AM
This revision is now accepted and ready to land.Mar 5 2018, 8:18 AM
jonpa closed this revision.Mar 5 2018, 11:30 AM

Thanks. r326716