[LNT] Make Run-Over-Run and Run-Over-Baseline changes an accordion.

[marxin]

Summary

Having a longer list of changes, it's handy to collapse one of them in order
to make it more readable.

[marxin]

May I please remind a patch review.

[MatzeB]

templates/reporting/runs.html reporting is also used to produce E-Mail reports I believe. And I'm not sure the E-Mail output has the CSS required for the accordions?

[MatzeB]

Maybe the answer here would be to further break up templates/reporting/runs.html into smaller pieces that can then be included from the WebUI and the E-Mail reports. So we can leave the accordions in the web-ui part. (That may be a bunch of refactoring though)

[cmatthews]

There might be a conditional or something set in the emails. I think there was other formatting magic that had to happen as well.

[cmatthews]

I think D4276: Added llvm.is.constant intrinsic was added in error. I have removed it.

[marxin]

With this patch:
https://reviews.llvm.org/D46186

I can send email and the according is file. Let's take a look here:
https://pasteboard.co/HiywaIE.png

[cmatthews]

LGTM. Thanks!

lnt/trunk/lnt/server/ui/templates/reporting/runs.html

<tr>
       <td style="{{ styles['td'] }}; text-align:right"><b>{{ num_total_tests }}</b></td>
       {% if baseline %}
       <td></td>
       {% endif %}
     </tr>
   </tfoot>
 </table>
 
+
+<section id="run_over_run">
+  {{ utils.render_popup_begin('run_over_run', 'Run-Over-Run Changes Detail', false, 'h3') }}
     <p>
-<h3>Run-Over-Run Changes Detail</h3>
     {% for _, field, bucket_name, sorted_bucket, test_names, show_perf in prioritized_buckets_run_over_run %}
       {% set field_index = ts.get_field_index(field) %}
       {{
         add_report_changes_detail_for_field_and_bucket(compare_to, field, show_perf, run_url, field_index, field.display_name,
                                                        bucket_name, sorted_bucket, test_names,
                                                        'Previous', '', ' (B)', run_to_baseline_info, styles, classes)
       }}
     {% endfor %}
     </p>
+  {{ utils.render_popup_end() }}
+</section>
+
+
+<section id="run_over_baseline">
+  {{ utils.render_popup_begin('run_over_baseline', 'Run-Over-Baseline Changes Detail', false, 'h3') }}
+    <p>
 {% if baseline %}
-<h3>Run-Over-Baseline Changes Detail</h3>
 {% for _, field, bucket_name, sorted_bucket, test_names, show_perf in prioritized_buckets_run_over_baseline %}
   {% set field_index = ts.get_field_index(field) %}
   {{
     add_report_changes_detail_for_field_and_bucket(baseline, field, show_perf, run_url, field_index, field.display_name,
                                                    bucket_name, sorted_bucket, test_names,
                                                    'Baseline', '(B)', '', run_to_run_info, styles, classes)
   }}
 {% endfor %}
 {% endif %}
+    </p>
+  {{ utils.render_popup_end() }}
+</section>
+
 <hr/>
 <b>Report Time</b>: {{ start_time | timedelta }}

lnt/trunk/lnt/server/ui/templates/utils.html

-{% macro render_popup_begin(id, title, hidden, depth=1) -%}
+{% macro render_popup_begin(id, title, hidden, element = 'span', depth=1) -%}
   <div class="accordion" id="{{id}}-accordion">
     <div class="accordion-group">
       <div class="accordion-heading">
-        <a class="accordion-toggle" data-toggle="collapse" data-parent="#{{id}}-accordion" href="#{{id}}-collapse">{{ title }}</a>
+          <{{element}}><a class="accordion-toggle" data-toggle="collapse" data-parent="#{{id}}-accordion" href="#{{id}}-collapse">{{ title }}</a></{{element}}>
       </div>
       <div id="{{id}}-collapse" class="accordion-body {{ 'collapse' if hidden else 'collapse in' }}">
         <div class="accordion-inner">
 {%- endmacro %}
 {% macro render_popup_end() -%}
         </div>
       </div>
     </div>