[LNT] Make content of send emails to be in utf-8.

[marxin]

Summary

Following patch is needed to handle properly:

/home/marxin/mysandbox/bin/python2 /home/marxin/mysandbox/bin/lnt send-run-comparison /home/marxin/Programming/lnt-instance 414 321 --from [e-mail] --host localhost  --to [e-mail] --testsuite SPEC
Traceback (most recent call last):
  File "/home/marxin/mysandbox/bin/lnt", line 11, in <module>
    load_entry_point('LNT', 'console_scripts', 'lnt')()
  File "/home/marxin/mysandbox/lib/python2.7/site-packages/click-6.7-py2.7.egg/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/marxin/mysandbox/lib/python2.7/site-packages/click-6.7-py2.7.egg/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/marxin/mysandbox/lib/python2.7/site-packages/click-6.7-py2.7.egg/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/marxin/mysandbox/lib/python2.7/site-packages/click-6.7-py2.7.egg/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/marxin/mysandbox/lib/python2.7/site-packages/click-6.7-py2.7.egg/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/marxin/Programming/lnt-marxinbox/lnt/lnttool/main.py", line 371, in action_send_run_comparison
    msg.attach(email.mime.text.MIMEText(html_report, 'html'))
  File "/usr/lib64/python2.7/email/mime/text.py", line 30, in __init__
    self.set_payload(_text, _charset)
  File "/usr/lib64/python2.7/email/message.py", line 226, in set_payload
    self.set_charset(charset)
  File "/usr/lib64/python2.7/email/message.py", line 262, in set_charset
    self._payload = self._payload.encode(charset.output_charset)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0394' in position 6113: ordinal not in range(128)

The problematic character is delta character:
http://www.fileformat.info/info/unicode/char/0394/index.htm

[cmatthews]

Thanks!

[cmatthews]

ping. Could you commit this. It is breaking somewhere for me! Thanks

lnt/trunk/lnt/lnttool/main.py

with contextlib.closing(config.get_database(database)) as db:
             filter_machine_regex=filter_machine_regex)
         report.build(session)
 
         logger.info("generating HTML report...")
         ts_url = "%s/db_%s/v4/%s" \
             % (config.zorgURL, database, testsuite)
         subject = "Daily Report: %04d-%02d-%02d" % (
             report.year, report.month, report.day)
-        html_report = report.render(ts_url, only_html_body=False)
+        html_report = report.render(ts_url, only_html_body=False).encode('utf-8')
 
         if subject_prefix is not None:
             subject = "%s %s" % (subject_prefix, subject)
 
         # Form the multipart email message.
         msg = email.mime.multipart.MIMEMultipart('alternative')
         msg['Subject'] = subject
         msg['From'] = from_address
         msg['To'] = address
-        msg.attach(email.mime.text.MIMEText(html_report, "html"))
+        msg.attach(email.mime.text.MIMEText(html_report, 'html', 'utf-8'))
 
         # Send the report.
         if not dry_run:
             s = smtplib.SMTP(host)
             s.sendmail(from_address, [address],
                        msg.as_string())
             s.quit()
         else:
with contextlib.closing(config.get_database(database)) as db:
 
         # Generate the report.
         data = lnt.server.reporting.runs.generate_run_data(
             session, run_b, baseurl=config.zorgURL, result=None,
             compare_to=run_a, baseline=None, aggregation_fn=min)
 
         env = lnt.server.ui.app.create_jinja_environment()
         text_template = env.get_template('reporting/run_report.txt')
-        text_report = text_template.render(data)
+        text_report = text_template.render(data).encode('utf-8')
         html_template = env.get_template('reporting/run_report.html')
-        html_report = html_template.render(data)
+        html_report = html_template.render(data).encode('utf-8')
 
         subject = data['subject']
         if subject_prefix is not None:
             subject = "%s %s" % (subject_prefix, subject)
 
         # Form the multipart email message.
         msg = email.mime.multipart.MIMEMultipart('alternative')
         msg['Subject'] = subject
         msg['From'] = from_address
         msg['To'] = to_address
-        msg.attach(email.mime.text.MIMEText(text_report, 'plain'))
-        msg.attach(email.mime.text.MIMEText(html_report, 'html'))
+        msg.attach(email.mime.text.MIMEText(text_report, 'plain', 'utf-8'))
+        msg.attach(email.mime.text.MIMEText(html_report, 'html', 'utf-8'))
 
         # Send the report.
         if not dry_run:
             mail_client = smtplib.SMTP(host)
             mail_client.sendmail(
                 from_address,
                 [to_address],
                 msg.as_string())

lnt/trunk/lnt/util/NTEmailReport.py

def emailReport(result, session, run, baseurl, email_config, to,
     # Ignore if no to address was given, we do things this way because of the
     # awkward way we collect result information as part of generating the email
     # report.
     if email_config is None or to is None:
         return
 
     # Generate a plain text message if we have no html report.
     if not html_report:
-        msg = email.mime.text.MIMEText(report)
+        msg = email.mime.text.MIMEText(report.encode('utf-8'), 'plain', 'utf-8')
         msg['Subject'] = subject
         msg['From'] = email_config.from_address
         msg['To'] = to
     else:
         msg = email.mime.multipart.MIMEMultipart('alternative')
         msg['Subject'] = subject
         msg['From'] = email_config.from_address
         msg['To'] = to
 
         # Attach parts into message container, according to RFC 2046, the last
         # part of a multipart message, in this case the HTML message, is best
         # and preferred.
-        msg.attach(email.mime.text.MIMEText(report, 'plain'))
-        msg.attach(email.mime.text.MIMEText(html_report, 'html'))
+        msg.attach(email.mime.text.MIMEText(report.encode('utf-8'), 'plain', 'utf-8'))
+        msg.attach(email.mime.text.MIMEText(html_report.encode('utf-8'), 'html', 'utf-8'))
 
     s = smtplib.SMTP(email_config.host)
     s.sendmail(email_config.from_address, [to], msg.as_string())
     s.quit()
 
 
 def _getReport(result, session, run, baseurl, was_added, compare_to=None):
     data = lnt.server.reporting.runs.generate_run_data(