This is an archive of the discontinued LLVM Phabricator instance.

Differential D43983

Update AMDGOUUsage.rst descriptions
ClosedPublic

Authored by t-tye on Mar 1 2018, 4:33 PM.

Details

Reviewers
kzhuravl
Commits
rG5bbcca6967ac: [AMDGPU] Update AMDGOUUsage.rst descriptions
rL326989: [AMDGPU] Update AMDGOUUsage.rst descriptions
Summary
  • Improve description of XNACK ELF flag.
  • Rename all uses of wave to wavefront to be consistent.

Diff Detail

Event Timeline

t-tye created this revision.Mar 1 2018, 4:33 PM
Herald added a subscriber: nhaehnle. · View Herald TranscriptMar 1 2018, 4:33 PM
t-tye updated this revision to Diff 136653.Mar 1 2018, 5:24 PM
t-tye retitled this revision from Update AMDGOUUsage.rst description of XNACK ELF flag to Update AMDGOUUsage.rst descriptions.
t-tye edited the summary of this revision. (Show Details)

Also rename all uses of wave to wavefront to be consistent.

kzhuravl accepted this revision.Mar 6 2018, 3:00 PM

LGTM.

This revision is now accepted and ready to land.Mar 6 2018, 3:00 PM
Closed by commit rL326989: [AMDGPU] Update AMDGOUUsage.rst descriptions (authored by t-tye). · Explain WhyMar 7 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
docs/
5 lines

Diff 136637

docs/AMDGPUUsage.rst

Show First 20 Lines • Show All 497 Lines • ▼ Show 20 Lines ``EF_AMDGPU_MACH`` 0x000000ff AMDGPU processor selection
mask for mask for
``EF_AMDGPU_MACH_xxx`` values ``EF_AMDGPU_MACH_xxx`` values
defined in defined in
:ref:`amdgpu-ef-amdgpu-mach-table`. :ref:`amdgpu-ef-amdgpu-mach-table`.
``EF_AMDGPU_XNACK`` 0x00000100 Indicates if the ``xnack`` ``EF_AMDGPU_XNACK`` 0x00000100 Indicates if the ``xnack``
target feature is target feature is
enabled for all code enabled for all code
contained in the code object. contained in the code object.
If the processor
does not support the
``xnack`` target
feature then must
be 0.
See See
:ref:`amdgpu-target-features`. :ref:`amdgpu-target-features`.
================================= ========== ============================= ================================= ========== =============================
.. table:: AMDGPU ``EF_AMDGPU_MACH`` Values .. table:: AMDGPU ``EF_AMDGPU_MACH`` Values
:name: amdgpu-ef-amdgpu-mach-table :name: amdgpu-ef-amdgpu-mach-table
================================= ========== ============================= ================================= ========== =============================
▲ Show 20 Lines • Show All 3,641 Lines • Show Last 20 Lines