This is an archive of the discontinued LLVM Phabricator instance.

[X86] Reject xmm16-31 in inline asm constraints when AVX512 is disabled
ClosedPublic

Authored by craig.topper on Mar 1 2018, 10:52 AM.

Reviewers

Commits

Summary

Fixes PR36532

I'm pretty sure we don't reject xmm8-xmm31 or r8-r15 in 32-bit mode either, but I'm starting with the filed bug.

LGTM

This revision is now accepted and ready to land.Mar 2 2018, 10:10 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Target/

X86/

9 lines

test/

CodeGen/

X86/

8 lines

Show First 20 Lines • Show All 39,149 Lines • ▼ Show 20 Lines	if (Constraint == "A") {
Res.first = X86::EAX;		Res.first = X86::EAX;
Res.second = &X86::GR32_ADRegClass;		Res.second = &X86::GR32_ADRegClass;
}		}
return Res;		return Res;
}		}
return Res;		return Res;
}		}

		// Make sure it isn't a register that requires AVX512.
		if (!Subtarget.hasAVX512() && isFRClass(*Res.second) &&
		TRI->getEncodingValue(Res.first) & 0x10) {
		// Register requires EVEX prefix.
		Res.first = 0;
		Res.second = nullptr;
		return Res;
		}

// Otherwise, check to see if this is a register class of the wrong value		// Otherwise, check to see if this is a register class of the wrong value
// type. For example, we want to map "{ax},i32" -> {eax}, we don't want it to		// type. For example, we want to map "{ax},i32" -> {eax}, we don't want it to
// turn into {ax},{dx}.		// turn into {ax},{dx}.
// MVT::Other is used to specify clobber names.		// MVT::Other is used to specify clobber names.
if (TRI->isTypeLegalForClass(*Res.second, VT) \|\| VT == MVT::Other)		if (TRI->isTypeLegalForClass(*Res.second, VT) \|\| VT == MVT::Other)
return Res; // Correct type already, nothing to do.		return Res; // Correct type already, nothing to do.

// Get a matching integer of the correct size. i.e. "ax" with MVT::32 should		// Get a matching integer of the correct size. i.e. "ax" with MVT::32 should
▲ Show 20 Lines • Show All 165 Lines • Show Last 20 Lines

				; RUN: not llc -o /dev/null %s 2>&1 \| FileCheck %s
				target triple = "x86_64--"

				; CHECK: error: couldn't allocate output register for constraint '{xmm16}'
				define i64 @blup() {
				%v = tail call i64 asm "", "={xmm16},0"(i64 0)
				ret i64 %v
				}