This patch extends the SPMD implementation to all target constructs and guards this implementation under a new flag.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Driver/ToolChains/Clang.cpp | ||
---|---|---|
3976–3977 ↗ | (On Diff #136214) | I think most other boolean options do the following: if (Args.hasFlag(...)) CmdArgs.push_back("...") Is there a reason we need this differently here? |
lib/Frontend/CompilerInvocation.cpp | ||
2533 ↗ | (On Diff #136214) | Yes, I'd also expect all SPMD constructs to default to CUDA mode. Or is there a case where this doesn't work? If yes, that should be explained in the summary. |
include/clang/Driver/Options.td | ||
---|---|---|
1428 ↗ | (On Diff #136214) | If you implement Jonas's suggested fix, no need to mark it as CC1Option |
lib/Driver/ToolChains/Clang.cpp | ||
3976–3977 ↗ | (On Diff #136214) | Agree, this looks much better |
lib/Frontend/CompilerInvocation.cpp | ||
2533 ↗ | (On Diff #136214) | Cuda mode is going to be the default for all constructs, as Generic mode is not ready yet. The codegen mode is not controlled by the construct, but by the option completely. |