This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Store LLVM_VERSION_SUFFIX in LLVMConfig.cmake
ClosedPublic

Authored by mgorny on Feb 23 2018, 3:58 PM.

Details

Summary

Store LLVM_VERSION_SUFFIX along with other version components
in LLVMConfig.cmake. This fixes preserving the suffix set while building
LLVM to stand-alone builds of other components, e.g. clang,
and therefore improves uniformity between the two build models.

Given that there is no apparent reason to omit this part of version,
that it is distributed to subprojects when building as part of LLVM
and that it is included in LLVM_PACKAGE_VERSION, I think it was omitted
accidentally rather than on purpose.

Diff Detail

Event Timeline

mgorny created this revision.Feb 23 2018, 3:58 PM

Erm, louder ping?

beanz accepted this revision.Aug 8 2018, 1:14 PM

Looks fine. Sorry for the extended delay in review.

This revision is now accepted and ready to land.Aug 8 2018, 1:14 PM
This revision was automatically updated to reflect the committed changes.