Notably helps cleanup after legalization of vector types
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
| lib/CodeGen/SelectionDAG/TargetLowering.cpp | ||
|---|---|---|
| 1359 ↗ | (On Diff #135629) | rename to SrcDemandedElts? |
| 1361–1362 ↗ | (On Diff #135629) | I think this would read more clearly as: |
| 1385–1386 ↗ | (On Diff #135629) | Similar to above: |
| 1398 ↗ | (On Diff #135629) | if -> it |
| test/CodeGen/X86/vector-shuffle-256-v16.ll | ||
| 4606–4609 ↗ | (On Diff #135629) | I haven't looked at this in a while, so not sure what's happening here, but this should just be: |
| test/CodeGen/X86/vector-shuffle-256-v16.ll | ||
|---|---|---|
| 4606–4609 ↗ | (On Diff #135629) | Its only broadcasting the lower i16 of the i32, so no unfortunately - in fact I think the test was added to make sure we don't do this. |
LGTM.
| test/CodeGen/X86/vector-shuffle-256-v16.ll | ||
|---|---|---|
| 4606–4609 ↗ | (On Diff #135629) | Oops, I should've noticed that from the AVX2 code. |