This is an archive of the discontinued LLVM Phabricator instance.

Fix llvm-pdbutil to handle new built-in types
ClosedPublic

Authored by amccarth on Feb 22 2018, 3:06 PM.

Details

Summary

The built-in PDB types enum has been extended to include char16_t and char32_t.
llvm-pdbutil was hitting an llvm_unreachable because it didn't know about these
new values. The new values are not yet in the DIA documentation, but are
listed in the cvconst.h header that comes as part of the DIA SDK.

Diff Detail

Repository
rL LLVM

Event Timeline

amccarth created this revision.Feb 22 2018, 3:06 PM
zturner accepted this revision.Feb 22 2018, 3:07 PM
This revision is now accepted and ready to land.Feb 22 2018, 3:07 PM
This revision was automatically updated to reflect the committed changes.