Page MenuHomePhabricator

[llvm-pdbdump] Dump restrict type qualifier
ClosedPublic

Authored by asmith on Feb 22 2018, 10:58 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

asmith created this revision.Feb 22 2018, 10:58 AM
asmith added a reviewer: rnk.
zturner accepted this revision.Feb 22 2018, 11:40 AM

Can you add a line for the function signature under the types section? We should see something like this:

int __cdecl(const volatile int* __restrict)

Aside from that, looks good.

This revision is now accepted and ready to land.Feb 22 2018, 11:40 AM

Thanks! This has a dependence on D43060 and will wait for that one before committing.

Yea, sorry about that, rnk is OOO right now, I'll tell him to look at it tomorrow.

majnemer added inline comments.
test/tools/llvm-pdbdump/Inputs/TypeQualifiersTest.cpp
40 ↗(On Diff #135472)

Extra semicolon?

asmith updated this revision to Diff 137038.Mar 5 2018, 10:28 AM
This revision was automatically updated to reflect the committed changes.
rnk added inline comments.Mar 5 2018, 10:36 AM
tools/llvm-pdbutil/PrettyFunctionDumper.cpp
249–252 ↗(On Diff #137038)

I'm pretty sure these modifiers go on the other side of the pointee type, like __restrict.

tools/llvm-pdbutil/PrettyTypedefDumper.cpp
51–54 ↗(On Diff #137038)

These probably go on the other side as well.