This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Include TEMP_MAX_LEN in Fuzzer::PrintStats.
ClosedPublic

Authored by morehouse on Feb 21 2018, 3:32 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

morehouse created this revision.Feb 21 2018, 3:32 PM
kcc added a comment.Feb 21 2018, 4:37 PM

ouch. 10 is too magic.
I've seen hundreds of these printed in a row, i.e. 10 will be too small.
in other cases 10 will be to large.
I wonder if we want to print it as one more number in regular Fuzzer::PrintStats lines, e.g. "lim: 123", like here:
#3145 REDUCE cov: 6 ft: 7 corp: 5/9b lim: 123 exec/s: 0 rss: 37Mb

If so, we'll need to also update the docs to explain what that is.

I am not sure, there might be another better way.

  • Revert "[libFuzzer] Reduce frequency of TEMP_MAX_LEN prints."
  • Print TEMP_MAX_LEN in Fuzzer::PrintStats.
  • Remove old TEMP_MAX_LEN print.
morehouse retitled this revision from [libFuzzer] Reduce frequency of TEMP_MAX_LEN prints. to [libFuzzer] Include TEMP_MAX_LEN in Fuzzer::PrintStats..Feb 22 2018, 10:48 AM
morehouse edited the summary of this revision. (Show Details)
kcc accepted this revision.Feb 22 2018, 10:54 AM

LGTM

This revision is now accepted and ready to land.Feb 22 2018, 10:54 AM
This revision was automatically updated to reflect the committed changes.