This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy] Use the full filename in --add-gnu-debuglink
ClosedPublic

Authored by arichardson on Feb 19 2018, 10:31 AM.

Details

Summary

The current implementation was writing the file name without the extension
whereas GNU objcopy writes the full filename. With this change GDB will now
load the .debug file instead of silently ignoring it.

Diff Detail

Event Timeline

arichardson created this revision.Feb 19 2018, 10:31 AM
jakehehrlich accepted this revision.Feb 19 2018, 11:47 AM

LGTM

I realized this a little while back but never got around to fixing it. Thanks!

This revision is now accepted and ready to land.Feb 19 2018, 11:47 AM
This revision was automatically updated to reflect the committed changes.