[clangd] Rename some protocol field to lower case

[malaperle]

Summary

Also fixes a GCC compilation error.

Signed-off-by: Marc-Andre Laperle <[e-mail]>

clang-tools-extra/trunk/clangd/Protocol.h

 bool fromJSON(const json::Expr &, TextDocumentPositionParams &);
 
 enum class MarkupKind {
   PlainText,
   Markdown,
 };
 
 struct MarkupContent {
-  MarkupKind Kind = MarkupKind::PlainText;
-  std::string Value;
+  MarkupKind kind = MarkupKind::PlainText;
+  std::string value;
 };
 json::Expr toJSON(const MarkupContent &MC);
 
 struct Hover {
   /// The hover's content
-  MarkupContent Contents;
+  MarkupContent contents;
 
   /// An optional range is a range inside a text document
   /// that is used to visualize a hover, e.g. by changing the background color.
-  llvm::Optional<Range> Range;
+  llvm::Optional<Range> range;
 };
 json::Expr toJSON(const Hover &H);
 
 /// The kind of a completion entry.
 enum class CompletionItemKind {
   Missing = 0,
   Text = 1,
   Method = 2,

clang-tools-extra/trunk/clangd/Protocol.cpp

case MarkupKind::PlainText:
     return "plaintext";
   case MarkupKind::Markdown:
     return "markdown";
   }
   llvm_unreachable("Invalid MarkupKind");
 }
 
 json::Expr toJSON(const MarkupContent &MC) {
-  if (MC.Value.empty())
+  if (MC.value.empty())
     return nullptr;
 
   return json::obj{
-      {"kind", toTextKind(MC.Kind)},
-      {"value", MC.Value},
+      {"kind", toTextKind(MC.kind)},
+      {"value", MC.value},
   };
 }
 
 json::Expr toJSON(const Hover &H) {
-  json::obj Result{{"contents", toJSON(H.Contents)}};
+  json::obj Result{{"contents", toJSON(H.contents)}};
 
-  if (H.Range.hasValue())
-    Result["range"] = toJSON(*H.Range);
+  if (H.range.hasValue())
+    Result["range"] = toJSON(*H.range);
 
   return std::move(Result);
 }
 
 json::Expr toJSON(const CompletionItem &CI) {
   assert(!CI.label.empty() && "completion item label is required");
   json::obj Result{{"label", CI.label}};
   if (CI.kind != CompletionItemKind::Missing)

clang-tools-extra/trunk/clangd/XRefs.cpp

 static Hover getHoverContents(const Decl *D) {
   Hover H;
   llvm::Optional<std::string> NamedScope = getScopeName(D);
 
   // Generate the "Declared in" section.
   if (NamedScope) {
     assert(!NamedScope->empty());
 
-    H.Contents.Value += "Declared in ";
-    H.Contents.Value += *NamedScope;
-    H.Contents.Value += "\n\n";
+    H.contents.value += "Declared in ";
+    H.contents.value += *NamedScope;
+    H.contents.value += "\n\n";
   }
 
   // We want to include the template in the Hover.
   if (TemplateDecl *TD = D->getDescribedTemplate())
     D = TD;
 
   std::string DeclText;
   llvm::raw_string_ostream OS(DeclText);
 
   PrintingPolicy Policy =
       PrintingPolicyForDecls(D->getASTContext().getPrintingPolicy());
 
   D->print(OS, Policy);
 
   OS.flush();
 
-  H.Contents.Value += DeclText;
+  H.contents.value += DeclText;
   return H;
 }
 
 /// Generate a \p Hover object given the macro \p MacroInf.
 static Hover getHoverContents(StringRef MacroName) {
   Hover H;
 
-  H.Contents.Value = "#define ";
-  H.Contents.Value += MacroName;
+  H.contents.value = "#define ";
+  H.contents.value += MacroName;
 
   return H;
 }
 
 Hover getHover(ParsedAST &AST, Position Pos) {
   const SourceManager &SourceMgr = AST.getASTContext().getSourceManager();
   const FileEntry *FE = SourceMgr.getFileEntryForID(SourceMgr.getMainFileID());
   if (FE == nullptr)

clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp

OneTest Tests[] = {
       },
   };
 
   for (const OneTest &Test : Tests) {
     Annotations T(Test.Input);
     auto AST = build(T.code());
     Hover H = getHover(AST, T.point());
 
-    EXPECT_EQ(H.Contents.Value, Test.ExpectedHover) << Test.Input;
+    EXPECT_EQ(H.contents.value, Test.ExpectedHover) << Test.Input;
   }
 }
 
 } // namespace
 } // namespace clangd
 } // namespace clang