This is an archive of the discontinued LLVM Phabricator instance.

Differential D4339

[libcxx] Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com>
AbandonedPublic

Authored by ajwong on Jun 28 2014, 2:06 AM.

Details

Reviewers
mclow.lists
Summary

Fixes compile failure on systems that qualify as "linux" but are not glibc based.

Diff Detail

Event Timeline

ajwong updated this revision to Diff 10960.Jun 28 2014, 2:06 AM
ajwong retitled this revision from to Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com>.
ajwong updated this object.
ajwong edited the test plan for this revision. (Show Details)
ajwong added a subscriber: Unknown Object (MLST).
ajwong retitled this revision from Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com> to [libcxx] Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com>.Jun 28 2014, 2:09 AM
ajwong added a reviewer: mclow.lists.Jun 28 2014, 2:19 AM

This time I think I got it right. Sorry for the spam.

danalbert added a subscriber: danalbert.Jun 28 2014, 9:46 AM

For Android, this isn't the whole truth. I actually have a patch waiting for review that covers this: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140623/108571.html

ajwong abandoned this revision.Jul 10 2014, 12:47 PM

danablert's change fixed this so closing.

Revision Contents

PathSize
include/
2 lines

Diff 10960

include/__config

Context not available.
#if defined(__FreeBSD__) #if defined(__FreeBSD__)
#define _LIBCPP_HAS_QUICK_EXIT #define _LIBCPP_HAS_QUICK_EXIT
#define _LIBCPP_HAS_C11_FEATURES #define _LIBCPP_HAS_C11_FEATURES
#elif defined(__linux__) #elif defined(__linux__) && defined(__GLIBC__)
#include <features.h> #include <features.h>
#if __GLIBC_PREREQ(2, 15) #if __GLIBC_PREREQ(2, 15)
#define _LIBCPP_HAS_QUICK_EXIT #define _LIBCPP_HAS_QUICK_EXIT
Context not available.