Page MenuHomePhabricator

ajwong (Albert Wong)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2013, 1:00 PM (451 w, 2 d)

Recent Activity

Aug 20 2014

ajwong added a comment to D4341: [libcxx] Correct SFINAE version of is_convertible to match spec and avoid triggering unnecessary compiler diagnostics.

gentle ping...

Aug 20 2014, 6:34 PM · deleted

Aug 6 2014

ajwong added a comment to D4817: [libcxx] [PATCH] Emulate clang atomic built-ins on gcc > 4.7.

This change is ready for review. With it, most of the libc++ atomic tests pass on gcc > 4.7.

Aug 6 2014, 3:59 PM · deleted
ajwong added a reviewer for D4817: [libcxx] [PATCH] Emulate clang atomic built-ins on gcc > 4.7: mclow.lists.
Aug 6 2014, 3:47 PM · deleted
ajwong updated D4817: [libcxx] [PATCH] Emulate clang atomic built-ins on gcc > 4.7.
Aug 6 2014, 3:46 PM · deleted
ajwong updated the diff for D4817: [libcxx] [PATCH] Emulate clang atomic built-ins on gcc > 4.7.
Aug 6 2014, 3:45 PM · deleted
ajwong retitled D4817: [libcxx] [PATCH] Emulate clang atomic built-ins on gcc > 4.7 from to Emulate clang atomic built-ins on gcc > 4.7.
Aug 6 2014, 3:22 PM · deleted

Aug 1 2014

ajwong updated the diff for D4341: [libcxx] Correct SFINAE version of is_convertible to match spec and avoid triggering unnecessary compiler diagnostics.

Addressed comments. PTAL

Aug 1 2014, 2:29 PM · deleted

Jul 10 2014

ajwong added a comment to D4341: [libcxx] Correct SFINAE version of is_convertible to match spec and avoid triggering unnecessary compiler diagnostics.

ping

Jul 10 2014, 12:48 PM · deleted
ajwong abandoned D4339: [libcxx] Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com>.

danablert's change fixed this so closing.

Jul 10 2014, 12:47 PM
ajwong added a comment to D4340: [libcxx] Take advantage of gcc4.7 frontend support in type_traits.

Thanks Marshall!

Jul 10 2014, 10:13 AM · deleted

Jul 8 2014

ajwong added a comment to D4340: [libcxx] Take advantage of gcc4.7 frontend support in type_traits.

gentle ping...

Jul 8 2014, 12:40 PM · deleted

Jun 30 2014

ajwong added a comment to D4329: [libcxx] Update the way the -std= flag is chosen by CMake and LibcxxTestFormat.
In D4329#22, @ajwong wrote:
In D4329#19, @rnk wrote:

I'm fine with dropping the ability to build libc++ with a C++03 compiler.
[ I'm *not* fine with dropping the ability to use libc++ from c++03 code ]

Responsible opposing viewpoints... ?

Albert, is the Android NDK version of GCC new enough?

NDK has both gcc-4.6 and gcc-4.8. I think we only expect libc++ to work with gcc-4.8 so we're probably okay. Let me verify with Andrew Hseih, head of android NDK. He's in Taiwan though so it'll be a few hours before he responds.

Jun 30 2014, 4:08 PM
ajwong added a comment to D4326: Revert the lsda change to scan_eh_tab..

IIRC, we might end up revisiting this later when we clean up cxxabi.h for
EHABI. In EHABI, there isn't a _Unwind_GetLanguageSpecificData() and this
modification was necessary to share code. We can revisit if/when someone
gets to cleaning up cxxabi.h.

Jun 30 2014, 4:05 PM
ajwong added a comment to D4329: [libcxx] Update the way the -std= flag is chosen by CMake and LibcxxTestFormat.
In D4329#19, @rnk wrote:

I'm fine with dropping the ability to build libc++ with a C++03 compiler.
[ I'm *not* fine with dropping the ability to use libc++ from c++03 code ]

Responsible opposing viewpoints... ?

Albert, is the Android NDK version of GCC new enough?

Jun 30 2014, 3:37 PM

Jun 28 2014

ajwong retitled D4341: [libcxx] Correct SFINAE version of is_convertible to match spec and avoid triggering unnecessary compiler diagnostics from to [libcxx] Correct SFINAE version of is_convertible to match spec and avoid triggering unnecessary compiler diagnostics.
Jun 28 2014, 2:24 AM · deleted
ajwong retitled D4340: [libcxx] Take advantage of gcc4.7 frontend support in type_traits from to [libcxx] Take advantage of gcc4.7 frontend support in type_traits.
Jun 28 2014, 2:22 AM · deleted
ajwong added a reviewer for D4339: [libcxx] Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com>: mclow.lists.

This time I think I got it right. Sorry for the spam.

Jun 28 2014, 2:19 AM
ajwong retitled D4339: [libcxx] Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com> from Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com> to [libcxx] Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com>.
Jun 28 2014, 2:09 AM
ajwong retitled D4339: [libcxx] Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com> from to Correct ifdef for glibc specific feature. Patch by David Turner <digit@android.com>.
Jun 28 2014, 2:06 AM
ajwong abandoned D492: Give regex_traits::__regex_word a proper definition..
Jun 28 2014, 2:03 AM