This is an archive of the discontinued LLVM Phabricator instance.

Render https producers as HTML hyperlinks too.
ClosedPublic

Authored by fhahn on Feb 14 2018, 8:22 AM.

Reviewers

kristof.beyls
cmatthews

Commits

rL326771: Render https producers as HTML hyperlinks too.

Since there is already a regex here, how about using a capture group on the protocol as well, then placing it back on the generated URL?

This revision now requires changes to proceed.Feb 14 2018, 10:33 AM

Thanks! I will update this patch when I am back, at the end of next week.

Update to check for https in buildbot URL too and add tests with https urls.

ping

Thx

This revision is now accepted and ready to land.Mar 5 2018, 5:01 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lnt/

server/

ui/

2 lines

Show First 20 Lines • Show All 222 Lines • ▼ Show 20 Lines	if m:

png_url = \		png_url = \
'http://%(url)s/png?builder=%(builder)s&number=%(build)s' % \		'http://%(url)s/png?builder=%(builder)s&number=%(build)s' % \
locals()		locals()
img = '<img src="%(png_url)s" />' % locals()		img = '<img src="%(png_url)s" />' % locals()
return '<a href="%(producer)s">%(builder)s #%(build)s %(img)s</a>' % \		return '<a href="%(producer)s">%(builder)s #%(build)s %(img)s</a>' % \
locals()		locals()

elif producer.startswith('http://'):		elif producer.startswith('http://') or producer.startswith('https://'):
return '<a href="' + producer + '">Producer</a>'		return '<a href="' + producer + '">Producer</a>'

else:		else:
return producer		return producer


FLASH_DANGER = "alert alert-danger"		FLASH_DANGER = "alert alert-danger"
FLASH_INFO = "alert alert-info"		FLASH_INFO = "alert alert-info"
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines