llvm-objdump: don't assert if ELF file has no sections

[emaste]

Summary

FreeBSD core files have no sections, and cause llvm-objdump to exit with an assertion failure.

llvm.org/pr20139

[t.p.northover]

Hi,

This looks fine to me.

Cheers.

Tim.

[emaste]

Closed by commit rL211904 (authored by @emaste).

llvm/trunk/include/llvm/Object/ELF.h

void ELFFile<ELFT>::VerifyStrTab(const Elf_Shdr *sh) const {
   if (strtab[sh->sh_size - 1] != 0)
     // FIXME: Proper error handling.
     report_fatal_error("String table must end with a null terminator!");
 }
 
 template <class ELFT>
 uint64_t ELFFile<ELFT>::getNumSections() const {
   assert(Header && "Header not initialized!");
-  if (Header->e_shnum == ELF::SHN_UNDEF) {
+  if (Header->e_shnum == ELF::SHN_UNDEF && Header->e_shoff > 0) {
     assert(SectionHeaderTable && "SectionHeaderTable not initialized!");
     return SectionHeaderTable->sh_size;
   }
   return Header->e_shnum;
 }
 
 template <class ELFT>
 typename ELFFile<ELFT>::uintX_t ELFFile<ELFT>::getStringTableIndex() const {