This is an archive of the discontinued LLVM Phabricator instance.

llvm-objdump: don't assert if ELF file has no sections
ClosedPublic

Authored by emaste on Jun 27 2014, 6:48 AM.

Reviewers

t.p.northover

Commits

Summary

FreeBSD core files have no sections, and cause llvm-objdump to exit with an assertion failure.

llvm.org/pr20139

emaste retitled this revision from to llvm-objdump: don't assert if ELF file has no sections.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste set the repository for this revision to rL LLVM.

emaste added a subscriber: Unknown Object (MLST).

Hi,

This looks fine to me.

Cheers.

Tim.

This revision is now accepted and ready to land.Jun 27 2014, 8:31 AM

Closed by commit rL211904 (authored by @emaste).

Path

Size

include/

llvm/

Object/

2 lines

Show First 20 Lines • Show All 596 Lines • ▼ Show 20 Lines	void ELFFile<ELFT>::VerifyStrTab(const Elf_Shdr *sh) const {
if (strtab[sh->sh_size - 1] != 0)		if (strtab[sh->sh_size - 1] != 0)
// FIXME: Proper error handling.		// FIXME: Proper error handling.
report_fatal_error("String table must end with a null terminator!");		report_fatal_error("String table must end with a null terminator!");
}		}

template <class ELFT>		template <class ELFT>
uint64_t ELFFile<ELFT>::getNumSections() const {		uint64_t ELFFile<ELFT>::getNumSections() const {
assert(Header && "Header not initialized!");		assert(Header && "Header not initialized!");
if (Header->e_shnum == ELF::SHN_UNDEF) {		if (Header->e_shnum == ELF::SHN_UNDEF && Header->e_shoff > 0) {
assert(SectionHeaderTable && "SectionHeaderTable not initialized!");		assert(SectionHeaderTable && "SectionHeaderTable not initialized!");
return SectionHeaderTable->sh_size;		return SectionHeaderTable->sh_size;
}		}
return Header->e_shnum;		return Header->e_shnum;
}		}

template <class ELFT>		template <class ELFT>
typename ELFFile<ELFT>::uintX_t ELFFile<ELFT>::getStringTableIndex() const {		typename ELFFile<ELFT>::uintX_t ELFFile<ELFT>::getStringTableIndex() const {
▲ Show 20 Lines • Show All 401 Lines • Show Last 20 Lines