This is an archive of the discontinued LLVM Phabricator instance.

Differential D43224

Fix typos.
ClosedPublic

Authored by brucem on Feb 12 2018, 11:22 PM.

Details

Reviewers
mclow.lists
EricWF
Commits
rGf684c9c83c62: Fix typos.
rCXX324989: Fix typos.
rL324989: Fix typos.

Diff Detail

Event Timeline

brucem created this revision.Feb 12 2018, 11:22 PM
EricWF accepted this revision.Feb 12 2018, 11:26 PM

LGTM.

This revision is now accepted and ready to land.Feb 12 2018, 11:26 PM
Closed by commit rL324989: Fix typos. (authored by brucem). · Explain WhyFeb 13 2018, 12:13 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 13 2018, 12:13 AM

Revision Contents

PathSize
docs/
DesignDocs/
2 lines
2 lines

Diff 133997

docs/DesignDocs/AvailabilityMarkup.rst

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
Testing Testing
======= =======
Some parameters can be passed to lit to run the test-suite and exercising the Some parameters can be passed to lit to run the test-suite and exercising the
availability. availability.
* The `platform` parameter controls the deployement target. For example lit can * The `platform` parameter controls the deployment target. For example lit can
be invoked with `--param=platform=macosx10.8`. Default is the current host. be invoked with `--param=platform=macosx10.8`. Default is the current host.
* The `use_system_cxx_lib` parameter indicates to use another library than the * The `use_system_cxx_lib` parameter indicates to use another library than the
just built one. Invoking lit with `--param=use_system_cxx_lib=true` will run just built one. Invoking lit with `--param=use_system_cxx_lib=true` will run
the test-suite against the host system library. Alternatively a path to the the test-suite against the host system library. Alternatively a path to the
directory containing a specific prebuilt libc++ can be used, for example: directory containing a specific prebuilt libc++ can be used, for example:
`--param=use_system_cxx_lib=/path/to/macOS/10.8/`. `--param=use_system_cxx_lib=/path/to/macOS/10.8/`.
* The `with_availability` boolean parameter enables the availability markup. * The `with_availability` boolean parameter enables the availability markup.
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines

docs/DesignDocs/CapturingConfigInfo.rst

Show All 40 Lines
============ ============
When you first configure libc++ using CMake we check to see if we need to When you first configure libc++ using CMake we check to see if we need to
capture any options. If we haven't been given any "persistent" options then capture any options. If we haven't been given any "persistent" options then
we do NOTHING. we do NOTHING.
Otherwise we create a custom installation rule that modifies the installed __config Otherwise we create a custom installation rule that modifies the installed __config
header. The rule first generates a dummy "__config_site" header containing the required header. The rule first generates a dummy "__config_site" header containing the required
#defines. The contents of the dummy header are then prependend to the installed #defines. The contents of the dummy header are then prepended to the installed
__config header. By manually prepending the files we avoid the cost of an __config header. By manually prepending the files we avoid the cost of an
extra #include and we allow the __config header to be ignorant of the extra extra #include and we allow the __config header to be ignorant of the extra
configuration all together. An example "__config" header generated when configuration all together. An example "__config" header generated when
-DLIBCXX_ENABLE_THREADS=OFF is given to CMake would look something like: -DLIBCXX_ENABLE_THREADS=OFF is given to CMake would look something like:
.. code-block:: cpp .. code-block:: cpp
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
Show All 31 Lines