This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Fix trailing space when printing pragmas
ClosedPublic

Authored by jdenny on Feb 12 2018, 12:04 PM.

Details

Summary

-ast-print prints omp pragmas with a trailing space. While this
behavior is likely of little concern to most users, surely it's
unintentional, and it's annoying for some source-level work I'm
pursuing. This patch focuses on omp pragmas, but it also fixes
init_seg and loop hint pragmas because they share implementation.

The testing strategy here is to add usually just one '{{$}}' per
relevant -ast-print test file. This seems to achieve good code
coverage. However, this strategy is probably easy to forget as the
tests evolve. That's probably fine as this fix is far from critical.
The main goal of the testing is to aid the initial review.

This patch also adds a fixme for "#pragma unroll", which prints as
"#pragma unroll (enable)", which is invalid syntax.

Diff Detail

Repository
rC Clang

Event Timeline

jdenny created this revision.Feb 12 2018, 12:04 PM
This revision is now accepted and ready to land.Feb 14 2018, 7:22 AM

LG

Alexey: Thanks for accepting. I do not have commit privileges. Would
you please commit for me?

This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.