This is an archive of the discontinued LLVM Phabricator instance.

[clang-move] Fix the incorrect expansion end location.
ClosedPublic

Authored by hokein on Feb 12 2018, 1:44 AM.

Details

Summary

Before the fix, if clang-move decides to move the following macro statement, it only moves the first line DEFINE(A,.

DEFINE(A,
               B);  
``

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Feb 12 2018, 1:44 AM

The fix is quite subtle and not obvious to tell from the test. Could you elaborate on the issue this fixes in the patch description? Thanks!

hokein edited the summary of this revision. (Show Details)Feb 12 2018, 4:18 AM
ioeric accepted this revision.Feb 12 2018, 4:21 AM

lgtm

This revision is now accepted and ready to land.Feb 12 2018, 4:21 AM
This revision was automatically updated to reflect the committed changes.