This is an archive of the discontinued LLVM Phabricator instance.

Prevent recursive MSan interceptors in fgets(3)
ClosedPublic

Authored by krytarowski on Feb 3 2018, 10:09 AM.

Reviewers

Commits

Summary

This corrects intercepting this call on NetBSD without false positives.

ping?

This revision is now accepted and ready to land.Feb 14 2018, 5:20 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

msan/

1 line

Show First 20 Lines • Show All 773 Lines • ▼ Show 20 Lines	INTERCEPTOR(int, socketpair, int domain, int type, int protocol, int sv[2]) {
int res = REAL(socketpair)(domain, type, protocol, sv);		int res = REAL(socketpair)(domain, type, protocol, sv);
if (!res)		if (!res)
__msan_unpoison(sv, sizeof(int[2]));		__msan_unpoison(sv, sizeof(int[2]));
return res;		return res;
}		}

INTERCEPTOR(char , fgets, char s, int size, void *stream) {		INTERCEPTOR(char , fgets, char s, int size, void *stream) {
ENSURE_MSAN_INITED();		ENSURE_MSAN_INITED();
		InterceptorScope interceptor_scope;
char *res = REAL(fgets)(s, size, stream);		char *res = REAL(fgets)(s, size, stream);
if (res)		if (res)
__msan_unpoison(s, REAL(strlen)(s) + 1);		__msan_unpoison(s, REAL(strlen)(s) + 1);
return res;		return res;
}		}

#if !SANITIZER_FREEBSD && !SANITIZER_NETBSD		#if !SANITIZER_FREEBSD && !SANITIZER_NETBSD
INTERCEPTOR(char , fgets_unlocked, char s, int size, void *stream) {		INTERCEPTOR(char , fgets_unlocked, char s, int size, void *stream) {
▲ Show 20 Lines • Show All 895 Lines • Show Last 20 Lines