This is an archive of the discontinued LLVM Phabricator instance.

Differential D42857

testing phabricator email reply
Needs ReviewPublic

Authored by ioeric on Feb 2 2018, 10:24 AM.

Download Raw Diff

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Diff Detail

Repository

rCTE Clang Tools Extra

Build Status

Buildable 14560
Build 14560: arc lint + arc unit

Event Timeline

ioeric created this revision.Feb 2 2018, 10:24 AM

Herald added subscribers: cfe-commits, klimek. · View Herald TranscriptFeb 2 2018, 10:24 AM

top Comment

change-namespace/ChangeNamespace.cpp
42	Test comment 1.

Harbormaster completed remote builds in B14560: Diff 132628.Feb 2 2018, 10:25 AM

Test email

Testemail

Test testemail

Test top reply.

top reply 13:42

top reply 10:52

change-namespace/ChangeNamespace.cpp
47	Testing inline comment reply.

top reply 10:39

top reply 10:57

top reply 10:35

Top in top+inline

top reply 10:30

Revision Contents

Path

Size

change-namespace/

ChangeNamespace.cpp

20 lines

Diff 132628

change-namespace/ChangeNamespace.cpp

	Show All 12 Lines

	using namespace clang::ast_matchers;			using namespace clang::ast_matchers;

	namespace clang {			namespace clang {
	namespace change_namespace {			namespace change_namespace {

	namespace {			namespace {

	inline std::string
	joinNamespaces(const llvm::SmallVectorImpl<StringRef> &Namespaces) {
	if (Namespaces.empty())
	return "";
	std::string Result = Namespaces.front();
	for (auto I = Namespaces.begin() + 1, E = Namespaces.end(); I != E; ++I)
	Result += ("::" + *I).str();
	return Result;
	}

	// Given "a::b::c", returns {"a", "b", "c"}.			// Given "a::b::c", returns {"a", "b", "c"}.
	llvm::SmallVector<llvm::StringRef, 4> splitSymbolName(llvm::StringRef Name) {			llvm::SmallVector<llvm::StringRef, 4> splitSymbolName(llvm::StringRef Name) {
	llvm::SmallVector<llvm::StringRef, 4> Splitted;			llvm::SmallVector<llvm::StringRef, 4> Splitted;
	Name.split(Splitted, "::", /MaxSplit=/-1,			Name.split(Splitted, "::", /MaxSplit=/-1,
	/KeepEmpty=/false);			/KeepEmpty=/false);
	return Splitted;			return Splitted;
	}			}

	SourceLocation startLocationForType(TypeLoc TLoc) {			SourceLocation startLocationForType(TypeLoc TLoc) {
	// For elaborated types (e.g. `struct a::A`) we want the portion after the			// For elaborated types (e.g. `struct a::A`) we want the portion after the
	// `struct` but including the namespace qualifier, `a::`.			// `struct` but including the namespace qualifier, `a::`.
	if (TLoc.getTypeLocClass() == TypeLoc::Elaborated) {			if (TLoc.getTypeLocClass() == TypeLoc::Elaborated) {
	NestedNameSpecifierLoc NestedNameSpecifier =			NestedNameSpecifierLoc NestedNameSpecifier =
	TLoc.castAs<ElaboratedTypeLoc>().getQualifierLoc();			TLoc.castAs<ElaboratedTypeLoc>().getQualifierLoc();
	if (NestedNameSpecifier.getNestedNameSpecifier())			if (NestedNameSpecifier.getNestedNameSpecifier())
	return NestedNameSpecifier.getBeginLoc();			return NestedNameSpecifier.getBeginLoc();
	TLoc = TLoc.getNextTypeLoc();			TLoc = TLoc.getNextTypeLoc();
	}			}
	return TLoc.getLocStart();			return TLoc.getLocStart();
	}			}

				inline std::string
				ioericAuthorUnsubmitted Not Done Reply Inline Actions Test comment 1. ioeric: Test comment 1.
				joinNamespaces(const llvm::SmallVectorImpl<StringRef> &Namespaces) {
				if (Namespaces.empty())
				return "";
				std::string Result = Namespaces.front();
				for (auto I = Namespaces.begin() + 1, E = Namespaces.end(); I != E; ++I)
				ioericAuthorUnsubmitted Not Done Reply Inline Actions Testing inline comment reply. ioeric: Testing inline comment reply.
				Result += ("::" + *I).str();
				return Result;
				}

	SourceLocation endLocationForType(TypeLoc TLoc) {			SourceLocation endLocationForType(TypeLoc TLoc) {
	// Dig past any namespace or keyword qualifications.			// Dig past any namespace or keyword qualifications.
	while (TLoc.getTypeLocClass() == TypeLoc::Elaborated \|\|			while (TLoc.getTypeLocClass() == TypeLoc::Elaborated \|\|
	TLoc.getTypeLocClass() == TypeLoc::Qualified)			TLoc.getTypeLocClass() == TypeLoc::Qualified)
	TLoc = TLoc.getNextTypeLoc();			TLoc = TLoc.getNextTypeLoc();

	// The location for template specializations (e.g. Foo<int>) includes the			// The location for template specializations (e.g. Foo<int>) includes the
	// templated types in its location range. We want to restrict this to just			// templated types in its location range. We want to restrict this to just
	▲ Show 20 Lines • Show All 956 Lines • Show Last 20 Lines