This is an archive of the discontinued LLVM Phabricator instance.

vpblend intrinsics combines as shifts intrinsics due to absence return stmt between them
ClosedPublic

Authored by rob.khasanov on Jun 24 2014, 10:46 AM.

Download Raw Diff

Details

Reviewers

nadav
andreadb

Commits

rG21c836823f9c: vpblend intrinsics combines as shifts intrinsics due to absence return stmt…
rL211617: vpblend intrinsics combines as shifts intrinsics due to absence return stmt…

Summary

Fix PR20088

Diff Detail

Event Timeline

rob.khasanov updated this revision to Diff 10796.Jun 24 2014, 10:46 AM

rob.khasanov retitled this revision from to vpblend intrinsics combines as shifts intrinsics due to absence return stmt between them.

rob.khasanov updated this object.

rob.khasanov edited the test plan for this revision. (Show Details)

rob.khasanov added reviewers: andreadb, nadav.

rob.khasanov set the repository for this revision to rL LLVM.

rob.khasanov added a subscriber: Unknown Object (MLST).

zinovy.nis added a subscriber: zinovy.nis.Jun 24 2014, 10:48 AM

Hi Robert,

Please address the two minor comments below related to the test.
Otherwise, the patch looks good to me.

Thanks!

test/CodeGen/X86/pr20088.ll
3–4	Remove the comment at line 3. Remove the reference to attribute group #0.
6–7	Remove the comment at line 6. Remove the reference to attribute group #1 since it is not defined.

This revision is now accepted and ready to land.Jun 24 2014, 10:59 AM

Hi Andrea,

Thanks for review, patch is updated

LGTM. Thanks :)

Closed by commit rL211617 (authored by rkhasanov).

Revision Contents

Path

Size

lib/

Target/

X86/

X86ISelLowering.cpp

2 lines

test/

CodeGen/

X86/

pr20088.ll

12 lines

Diff 10796

lib/Target/X86/X86ISelLowering.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 19,182 Lines • ▼ Show 20 Lines	case Intrinsic::x86_sse41_pblendvb: {

// Simplify the case where the mask is a constant i32 value.		// Simplify the case where the mask is a constant i32 value.
if (ConstantSDNode *C = dyn_cast<ConstantSDNode>(Mask)) {		if (ConstantSDNode *C = dyn_cast<ConstantSDNode>(Mask)) {
if (C->isNullValue())		if (C->isNullValue())
return Op0;		return Op0;
if (C->isAllOnesValue())		if (C->isAllOnesValue())
return Op1;		return Op1;
}		}

		return SDValue();
}		}

// Packed SSE2/AVX2 arithmetic shift immediate intrinsics.		// Packed SSE2/AVX2 arithmetic shift immediate intrinsics.
case Intrinsic::x86_sse2_psrai_w:		case Intrinsic::x86_sse2_psrai_w:
case Intrinsic::x86_sse2_psrai_d:		case Intrinsic::x86_sse2_psrai_d:
case Intrinsic::x86_avx2_psrai_w:		case Intrinsic::x86_avx2_psrai_w:
case Intrinsic::x86_avx2_psrai_d:		case Intrinsic::x86_avx2_psrai_d:
case Intrinsic::x86_sse2_psra_w:		case Intrinsic::x86_sse2_psra_w:
▲ Show 20 Lines • Show All 2,679 Lines • Show Last 20 Lines

test/CodeGen/X86/pr20088.ll

This file was added.

				; RUN: llc < %s -mattr=+avx \| FileCheck %s

				; Function Attrs: nounwind readnone
				declare <16 x i8> @llvm.x86.sse41.pblendvb(<16 x i8>, <16 x i8>, <16 x i8>) #0
				andreadbUnsubmitted Not Done Reply Inline Actions Remove the comment at line 3. Remove the reference to attribute group #0. andreadb: Remove the comment at line 3. Remove the reference to attribute group #0.

				; Function Attrs: nounwind
				define <16 x i8> @foo(<16 x i8> %x) #1 {
				andreadbUnsubmitted Not Done Reply Inline Actions Remove the comment at line 6. Remove the reference to attribute group #1 since it is not defined. andreadb: Remove the comment at line 6. Remove the reference to attribute group #1 since it is not…
				; CHECK: vpblendvb
				%res = call <16 x i8> @llvm.x86.sse41.pblendvb(<16 x i8> zeroinitializer, <16 x i8> <i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1, i8 1>, <16 x i8> %x)
				ret <16 x i8> %res;
				}