This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [COFF] Remove the temporary file if not updating the import library
ClosedPublic

Authored by mstorsjo on Jan 28 2018, 4:50 AM.

Reviewers

Commits

Good catch, thanks! LGTM.

This revision is now accepted and ready to land.Jan 29 2018, 2:07 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

COFF/

2 lines

Show First 20 Lines • Show All 566 Lines • ▼ Show 20 Lines	if (Error E = writeImportLibrary(LibName, TmpName, Exports, Config->Machine,
HandleError(std::move(E));		HandleError(std::move(E));
return;		return;
}		}

std::unique_ptr<MemoryBuffer> NewBuf = check(MemoryBuffer::getFile(TmpName));		std::unique_ptr<MemoryBuffer> NewBuf = check(MemoryBuffer::getFile(TmpName));
if ((*OldBuf)->getBuffer() != NewBuf->getBuffer()) {		if ((*OldBuf)->getBuffer() != NewBuf->getBuffer()) {
OldBuf->reset();		OldBuf->reset();
HandleError(errorCodeToError(sys::fs::rename(TmpName, Path)));		HandleError(errorCodeToError(sys::fs::rename(TmpName, Path)));
		} else {
		sys::fs::remove(TmpName);
}		}
}		}

static void parseModuleDefs(StringRef Path) {		static void parseModuleDefs(StringRef Path) {
std::unique_ptr<MemoryBuffer> MB = CHECK(		std::unique_ptr<MemoryBuffer> MB = CHECK(
MemoryBuffer::getFile(Path, -1, false, true), "could not open " + Path);		MemoryBuffer::getFile(Path, -1, false, true), "could not open " + Path);
COFFModuleDefinition M = check(parseCOFFModuleDefinition(		COFFModuleDefinition M = check(parseCOFFModuleDefinition(
MB->getMemBufferRef(), Config->Machine, Config->MinGW));		MB->getMemBufferRef(), Config->Machine, Config->MinGW));
▲ Show 20 Lines • Show All 843 Lines • Show Last 20 Lines