This is an archive of the discontinued LLVM Phabricator instance.

Fix -fmodules build after rL323277
AbandonedPublic

Authored by arichardson on Jan 24 2018, 2:29 PM.

Details

Reviewers
chapuni
bkramer
Summary

Since rL323277 utils/TableGen/CodeGenSchedule.cpp pulls in "llvm/CodeGen/TargetOpcodes.h".
This currently attempts to build the whole llvm/CodeGen module which will try to add
LLVM/IR/Attributes.h. This headers #include "llvm/IR/Attributes.gen" which needs to be
built by tablegen so the build failed.

As a workaround I marked llvm/CodeGen/TargetOpcodes.h as a textual header. I am not sure if that is the correct solution but at least the build passes again for me.

Diff Detail

Event Timeline

arichardson created this revision.Jan 24 2018, 2:29 PM

I went a slightly different route in rL323383, but this would've worked too. The layering between CodeGen and TableGen is messy, we'll have to clean that up eventually :(

arichardson abandoned this revision.Jan 24 2018, 4:56 PM