It looks like this hasn't been updated since bugzilla moved.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
LGTM.
For future reference, you should upload diffs with more context (-U9999, or just use arcanist). This is trivial so it doesn't matter that much. It's also a good idea to add some reviewers explicitly, otherwise it's easy for things to slip through on the mailing list.
Do you have commit access?
Thanks for reviewing this for me!
For future reference, you should upload diffs with more context (-U9999, or just use arcanist). This is trivial so it doesn't matter that much. It's also a good idea to add some reviewers explicitly, otherwise it's easy for things to slip through on the mailing list.
I did use arcanist, is there a special config option I have to set or something? I'm on Windows too, so maybe that's it? I'll dig around the internet to see if I can fix it for next time.
Good call on the reviewers, I usually do a blame to see who to send these to, but it just slipped my mind this time :)
Do you have commit access?
I do not. I'd really appreciate it if you'd submit this for me!
Thanks again!
arc diff should submit a diff with full context by default, but arc in general isn't entirely sane on Windows, so it wouldn't surprise me if it's doing something silly.
Yup, found it: https://secure.phabricator.com/T2465
Looks like there's a good workaroud in there, I'll try that in the future.
Thanks for submitting!