Page MenuHomePhabricator

[X86][SSE] LowerBUILD_VECTORAsVariablePermute - fix PSHUFB source/index operand ordering
ClosedPublic

Authored by RKSimon on Jan 22 2018, 9:07 AM.

Details

Summary

As detailed in rL317463, PSHUFB (like most variable shuffle instructions) uses Op[0] for the source vector and Op[1] for the shuffle index vector, VPERMV works in reverse which is probably where the confusion comes from.

Diff Detail

Repository
rL LLVM

Event Timeline

RKSimon created this revision.Jan 22 2018, 9:07 AM
This revision is now accepted and ready to land.Jan 22 2018, 7:10 PM
zvi added a comment.Jan 23 2018, 2:00 AM

Thanks for the fix.

This revision was automatically updated to reflect the committed changes.